Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pb-4579: Passing --sseType to kopia only when S3Config.SseType is passed #314

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

siva-portworx
Copy link
Contributor

@siva-portworx siva-portworx commented Oct 9, 2023

What this PR does / why we need it:

pb-4579: Passing --sseType to kopia only when S3Config.SseType is passed.

Which issue(s) this PR fixes (optional)
Closes # pb-4579

Special notes for your reviewer:
Added minor fix in the kopia source, to make sse-type as optional.
Before Fix:

cmd.Flag("sseType", "SSE types, only SSE-S3 is supported.").Required().StringVar(&c.s3options.SseType)

After Fix:

cmd.Flag("sseType", "SSE types, only SSE-S3 is supported.").Default("").StringVar(&c.s3options.SseType)

Will add the test result in the Px-backup PR and will add a reference to it.
https://github.com/portworx/px-backup/pull/1352 - px-backup PR

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

OSS Scan Results:

Title Severity Package Name CVEs Fix version Introduced

Total issues: 0

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

License Evaluation Results:

Title Package Name Package Version Severity License Info Introduced
MPL-2.0 license github.com/hashicorp/errwrap 1.1.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/snapshot/controllers@#29f495ef07e2', 'github.com/hashicorp/[email protected]', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-multierror 1.1.1 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/snapshot/controllers@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/k8sutils@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/resourcecollector@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/csi@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/k8sutils@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/aws@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/k8sutils@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/azure@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/k8sutils@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/kdmp@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/k8sutils@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/gcp@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/k8sutils@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/snapshot/controllers@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/snapshotter@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/k8sutils@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/applicationmanager/controllers@#29f495ef07e2', 'github.com/libopenstorage/stork/drivers/volume/kdmp@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/k8sutils@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
Unknown license github.com/rancher/wrangler/pkg/name 1.1.0 high Unknown ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/applicationmanager/controllers@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/platform/rancher@#29f495ef07e2', 'github.com/rancher/rancher/pkg/client/generated/management/v3@#a67566517525', 'github.com/rancher/norman/types@#275a3e921940', 'github.com/rancher/wrangler/pkg/[email protected]']
Unknown license github.com/rancher/wrangler/pkg/name 1.1.0 high Unknown ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/csi@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/applicationmanager/controllers@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/platform/rancher@#29f495ef07e2', 'github.com/rancher/rancher/pkg/client/generated/management/v3@#a67566517525', 'github.com/rancher/norman/types@#275a3e921940', 'github.com/rancher/wrangler/pkg/[email protected]']
Unknown license github.com/rancher/wrangler/pkg/name 1.1.0 high Unknown ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/applicationmanager/controllers@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/platform/rancher@#29f495ef07e2', 'github.com/rancher/rancher/pkg/client/generated/management/v3@#a67566517525', 'github.com/rancher/norman/types@#275a3e921940', 'github.com/rancher/wrangler/pkg/[email protected]']

Total License Issues: 19

@siva-portworx siva-portworx merged commit 1595007 into master Oct 10, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants