Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PB-5200: vendor stork master to Skip Default Kubernetes endpoint during the backup #330

Closed
wants to merge 1 commit into from

Conversation

sgajawada-px
Copy link
Contributor

@sgajawada-px sgajawada-px commented Dec 26, 2023

RCA
In the KDMP the util ResourceCollector.GetResourcesForType is not updated with the latest(code fix by pallav) nfsexecutor causing the issue.

Solution Approach
Import and building the fix stork change to the kdmp and build the nfs executor with the appropriate tag solved the issue.
Branching for 2.7.0 will also fix the issue.

vendor stork master 8b9683c22483 to Skip Default Kubernetes Endpoint while taking backup in nfs BL. The NFS executor which takes the backup

What this PR does / why we need it:
This is a regression issue to the bug https://portworx.atlassian.net/browse/PB-4632

Which issue(s) this PR fixes (optional)
Closes #PB-5200

Special notes for your reviewer:
Unit Test Results
Kubernetes endpoint is not getting backup(can see under the resources section in the below image) with the above mentioned solution approach.
Screenshot from 2023-12-26 23-24-07
Screenshot from 2023-12-26 23-23-42
Screenshot from 2023-12-26 23-23-41

Copy link

License Evaluation Results:

Title Package Name Package Version Severity License Info Introduced
MPL-2.0 license github.com/hashicorp/errwrap 1.1.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#8b9683c22483', 'github.com/libopenstorage/stork/pkg/snapshot/controllers@#8b9683c22483', 'github.com/hashicorp/[email protected]', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-multierror 1.1.1 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#8b9683c22483', 'github.com/libopenstorage/stork/pkg/snapshot/controllers@#8b9683c22483', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/version@#8b9683c22483', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#8b9683c22483', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/k8sutils@#8b9683c22483', 'github.com/libopenstorage/stork/pkg/version@#8b9683c22483', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/resourcecollector@#8b9683c22483', 'github.com/libopenstorage/stork/pkg/version@#8b9683c22483', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/csi@#8b9683c22483', 'github.com/libopenstorage/stork/pkg/version@#8b9683c22483', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume@#8b9683c22483', 'github.com/libopenstorage/stork/pkg/k8sutils@#8b9683c22483', 'github.com/libopenstorage/stork/pkg/version@#8b9683c22483', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/aws@#8b9683c22483', 'github.com/libopenstorage/stork/pkg/k8sutils@#8b9683c22483', 'github.com/libopenstorage/stork/pkg/version@#8b9683c22483', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/azure@#8b9683c22483', 'github.com/libopenstorage/stork/pkg/k8sutils@#8b9683c22483', 'github.com/libopenstorage/stork/pkg/version@#8b9683c22483', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/kdmp@#8b9683c22483', 'github.com/libopenstorage/stork/pkg/k8sutils@#8b9683c22483', 'github.com/libopenstorage/stork/pkg/version@#8b9683c22483', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/gcp@#8b9683c22483', 'github.com/libopenstorage/stork/pkg/k8sutils@#8b9683c22483', 'github.com/libopenstorage/stork/pkg/version@#8b9683c22483', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#8b9683c22483', 'github.com/libopenstorage/stork/pkg/snapshot/controllers@#8b9683c22483', 'github.com/libopenstorage/stork/pkg/version@#8b9683c22483', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/snapshotter@#8b9683c22483', 'github.com/libopenstorage/stork/pkg/k8sutils@#8b9683c22483', 'github.com/libopenstorage/stork/pkg/version@#8b9683c22483', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/applicationmanager/controllers@#8b9683c22483', 'github.com/libopenstorage/stork/drivers/volume/kdmp@#8b9683c22483', 'github.com/libopenstorage/stork/pkg/k8sutils@#8b9683c22483', 'github.com/libopenstorage/stork/pkg/version@#8b9683c22483', 'github.com/hashicorp/[email protected]']
Unknown license github.com/rancher/wrangler/pkg/name 1.1.0 high Unknown ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/applicationmanager/controllers@#8b9683c22483', 'github.com/libopenstorage/stork/pkg/platform/rancher@#8b9683c22483', 'github.com/rancher/rancher/pkg/client/generated/management/v3@#a67566517525', 'github.com/rancher/norman/types@#275a3e921940', 'github.com/rancher/wrangler/pkg/[email protected]']
Unknown license github.com/rancher/wrangler/pkg/name 1.1.0 high Unknown ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/csi@#8b9683c22483', 'github.com/libopenstorage/stork/pkg/applicationmanager/controllers@#8b9683c22483', 'github.com/libopenstorage/stork/pkg/platform/rancher@#8b9683c22483', 'github.com/rancher/rancher/pkg/client/generated/management/v3@#a67566517525', 'github.com/rancher/norman/types@#275a3e921940', 'github.com/rancher/wrangler/pkg/[email protected]']
Unknown license github.com/rancher/wrangler/pkg/name 1.1.0 high Unknown ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#8b9683c22483', 'github.com/libopenstorage/stork/pkg/applicationmanager/controllers@#8b9683c22483', 'github.com/libopenstorage/stork/pkg/platform/rancher@#8b9683c22483', 'github.com/rancher/rancher/pkg/client/generated/management/v3@#a67566517525', 'github.com/rancher/norman/types@#275a3e921940', 'github.com/rancher/wrangler/pkg/[email protected]']

Total License Issues: 19

@sgajawada-px
Copy link
Contributor Author

The branching for 2.7.0 solved the issue using the kdmp image tage 1.2.12
Ref: https://purestorage.slack.com/archives/C066EUL4CMD/p1704794129825879
Please find the unit test attachments for the same.
Screenshot from 2024-01-11 04-33-45
Screenshot from 2024-01-11 04-33-40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant