-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PB-5200: vendor stork master to Skip Default Kubernetes endpoint during the backup #330
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Endpoint while taking backup in nfs BL
License Evaluation Results:
Total License Issues: 19 |
The branching for 2.7.0 solved the issue using the kdmp image tage 1.2.12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RCA
In the KDMP the util ResourceCollector.GetResourcesForType is not updated with the latest(code fix by pallav) nfsexecutor causing the issue.
Solution Approach
Import and building the fix stork change to the kdmp and build the nfs executor with the appropriate tag solved the issue.
Branching for 2.7.0 will also fix the issue.
vendor stork master 8b9683c22483 to Skip Default Kubernetes Endpoint while taking backup in nfs BL. The NFS executor which takes the backup
What this PR does / why we need it:
This is a regression issue to the bug https://portworx.atlassian.net/browse/PB-4632
Which issue(s) this PR fixes (optional)
Closes #PB-5200
Special notes for your reviewer:
Unit Test Results
Kubernetes endpoint is not getting backup(can see under the resources section in the below image) with the above mentioned solution approach.