-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PB-4572:Added logging of pod describe,events and Jobpod log in job failure scenarios #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OSS Scan Results:
Total issues: 179 |
License Evaluation Results:
Total License Issues: 19 |
dbinnal-px
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
aks-px
force-pushed
the
PB-4572
branch
2 times, most recently
from
January 29, 2024 17:17
4c120e4
to
41d9ec1
Compare
aks-px
changed the title
PB-4572:Add utility function for printing job pod description,log and events
PB-4572:Added logging of pod describe,events and Jobpod log in job failure scenarios
Jan 30, 2024
OSS Scan Results:
Total issues: 47 |
License Evaluation Results:
Total License Issues: 19 |
OSS Scan Results:
Total issues: 47 |
License Evaluation Results:
Total License Issues: 19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
1.Added utility function to display the job pod log,events and description.
Added the call to the jobStatus function where we check the status of job to print logs in case of failure.
2.Code cleanup: Removed unnecessary err!=nil blocks and removed appendPodLogtoStork function
3.Fix label for NFSCSIrestore job which was pointing to NFSRestore before
Which issue(s) this PR fixes (optional)
Closes #PB-4572
Special notes for your reviewer:
Screenshots of
1.kopiabackup driver mountfailed and job failed:
2.nfsbackup mount and job failed:
kopiarestore mount fail:
nfsrestore mount and job fail:
NFSCSIrestore:
Delete and maintenace related screenshot will be added in the PR for px-backup