Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pb-5450: Added change to wait for the deletion of application pvc before switching to kdmp restore, when the csi restore failed. #338

Merged
merged 1 commit into from
Feb 1, 2024
Merged

pb-5450: Added change to wait for the deletion of application pvc before switching to kdmp restore, when the csi restore failed. #338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pkg/controllers/dataexport/reconcile.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1629,6 +1629,12 @@ func (c *Controller) cleanupLocalRestoredSnapshotResources(de *kdmpapi.DataExpor
if err := core.Instance().DeletePersistentVolumeClaim(pvcSpec.Name, de.Namespace); err != nil && !k8sErrors.IsNotFound(err) {
return nil, false, fmt.Errorf("delete %s/%s pvc: %s", de.Namespace, pvcSpec.Name, err)
}
// If local csi restore fails, we will delete the PVC created to restore from local csi snapshot.
// Will wait for the deletion of the PVC to complete by calling get PVC.
// Otherwise, the PVC creation in the kdmp snapshot restore, does not creates the new PVC as we will use same name.
if _, err := core.Instance().GetPersistentVolumeClaim(pvcSpec.Name, de.Namespace); (err != nil && !k8sErrors.IsNotFound(err)) || (err == nil) {
return nil, true, fmt.Errorf("get %v/%v pvc: %v", de.Namespace, pvcSpec.Name, err)
}
}
return nil, false, nil
}
Expand Down
Loading