-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging 1.2.11 changes to kdmp master #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kesavan thiruvenkadasamy <[email protected]>
Signed-off-by: kesavan thiruvenkadasamy <[email protected]>
upgraded GoLang version to fix high cve's
capturing actual error msg while trying to check if repo exists
Signed-off-by: kesavan thiruvenkadasamy <[email protected]>
- Currently, with Istio enabled on a namespace, it will create istio-proxy container for all the pods. With the job pod, there is a known issue where even though the actual job pod container completes, the istio-proxy continues to runs. This makes the job pod to hang. - This issue is fixed with k8s 1.28.0 and Istion 1.19.0. Still that point, we are providing a option to customer such they can set the KDMP_DISABLE_ISTIO_CONFIG to true in the kdmp-confg configmap and we will add the "sidecar.istio.io/inject: false" labels to the job pod that we create. That way the istio-proxy container will not be added to the job pod, even if the Istio is enabled at the namespace.
pb-5288: Adding "sidecar.istio.io/injec: false" label to the job pods.
…p-config for delete and maintenance apis.
pb-5288: Added changes to read the istio disable config from px-backup-config for delete and maintenance apis.
switching to kdmp restore, when the csi restore failed.
pb-5450: Added change to wait for the deletion of application pvc before switching to kdmp restore, when the csi restore failed.
lalat-das
requested review from
diptiranjanpx,
px-kesavan,
prashanthpx and
siva-portworx
and removed request for
diptiranjanpx and
px-kesavan
February 5, 2024 08:51
OSS Scan Results:
Total issues: 47 |
License Evaluation Results:
Total License Issues: 19 |
siva-portworx
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: We need to move to stork master branch instead of maintaining a private branch Hence kdmp master need to be up-to-date i.e. bring 1.2.11 changes to master so that kdmp-master can be vendored to stork master with all the latest changes for 2.7.0 release.
Which issue(s) this PR fixes (optional)
Closes #
Special notes for your reviewer:
Intentionally all the vendor commits are kept instead of ripping them off so that got log and bisect etc will work properly for any given commit.