Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pb-5438: Resetting the pvc.Spec.Selector in the kdmp and csi as it is dynamic provisioning. #343

Merged
merged 1 commit into from
Feb 19, 2024
Merged

pb-5438: Resetting the pvc.Spec.Selector in the kdmp and csi as it is dynamic provisioning. #343

merged 1 commit into from
Feb 19, 2024

Conversation

siva-portworx
Copy link
Contributor

What this PR does / why we need it:

pb-5438: Resetting the pvc.Spec.Selector in the kdmp and csi as it is dynamic provisioning.

Which issue(s) this PR fixes (optional)
Closes # pb-5438

Special notes for your reviewer:
Note:

One PR will raised in stork code to take care of CSI in the RestoreFromLocalSnapshot function of /pkg/snapshotter/snapshotter_csi.go file.

Testing:

  1. Created a static NFS pv and linked it with the PVC with a label selector:
➜  ~ kubectl get pvc -n nfs-test -o yaml
apiVersion: v1
items:
- apiVersion: v1
  kind: PersistentVolumeClaim
  metadata:
    annotations:
      kubectl.kubernetes.io/last-applied-configuration: |
        {"apiVersion":"v1","kind":"PersistentVolumeClaim","metadata":{"annotations":{},"name":"nfs-pvc","namespace":"nfs-test"},"spec":{"accessModes":["ReadWriteMany"],"resources":{"requests":{"storage":"1Gi"}},"selector":{"matchLabels":{"app":"test"}}}}
      pv.kubernetes.io/bind-completed: "yes"
      pv.kubernetes.io/bound-by-controller: "yes"
    creationTimestamp: "2024-02-04T09:03:50Z"
    finalizers:
    - kubernetes.io/pvc-protection
    name: nfs-pvc
    namespace: nfs-test
    resourceVersion: "4267466"
    uid: 2376b597-5648-4792-a1a9-dade13f71876
  spec:
    accessModes:
    - ReadWriteMany
    resources:
      requests:
        storage: 1Gi
    selector:
      matchLabels:
        app: test
    volumeMode: Filesystem
    volumeName: nfs-pv
  status:
    accessModes:
    - ReadWriteMany
    capacity:
      storage: 1Gi
    phase: Bound
kind: List
metadata:
  resourceVersion: ""
  selfLink: ""
➜  ~ kubectl get pv nfs-pv  -o yaml
apiVersion: v1
kind: PersistentVolume
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"v1","kind":"PersistentVolume","metadata":{"annotations":{},"labels":{"app":"test"},"name":"nfs-pv"},"spec":{"accessModes":["ReadWriteMany"],"capacity":{"storage":"1Gi"},"nfs":{"path":"/mnt/pvc1","server":"10.13.210.251"}}}
    pv.kubernetes.io/bound-by-controller: "yes"
  creationTimestamp: "2024-02-04T09:00:53Z"
  finalizers:
  - kubernetes.io/pv-protection
  labels:
    app: test
  name: nfs-pv
  resourceVersion: "4267464"
  uid: 6927c09f-919d-40db-9259-8fb59d67cb40
spec:
  accessModes:
  - ReadWriteMany
  capacity:
    storage: 1Gi
  claimRef:
    apiVersion: v1
    kind: PersistentVolumeClaim
    name: nfs-pvc
    namespace: nfs-test
    resourceVersion: "4267462"
    uid: 2376b597-5648-4792-a1a9-dade13f71876
  nfs:
    path: /mnt/pvc1
    server: 10.13.210.251
  persistentVolumeReclaimPolicy: Retain
  volumeMode: Filesystem
status:
  phase: Bound
➜  ~

With out fix, it failing while restore as restore PVC was struck in "Pending" state"

➜  ~ kubectl get pvc -n res2
NAME                               STATUS    VOLUME                            CAPACITY   ACCESS MODES   STORAGECLASS                AGE
nfs-pvc                            Pending                                                               ocs-storagecluster-cephfs   54s
pvc-nfs-restore-pvc-2d532ab-res2   Bound     pv-nfs-restore-pvc-2d532ab-res2   10Gi       RWX                                        88s
➜  ~ kubectl get events -n res2
LAST SEEN   TYPE      REASON                 OBJECT                                   MESSAGE
6s          Normal    ExternalProvisioning   persistentvolumeclaim/nfs-pvc            waiting for a volume to be created, either by external provisioner "openshift-storage.cephfs.csi.ceph.com" or manually created by system administrator
2s          Normal    Provisioning           persistentvolumeclaim/nfs-pvc            External provisioner is provisioning volume for claim "res2/nfs-pvc"
2s          Warning   ProvisioningFailed     persistentvolumeclaim/nfs-pvc            failed to provision volume with StorageClass "ocs-storagecluster-cephfs": claim Selector is not supported
94s         Normal    Scheduled              pod/nfs-restore-pvc-2d532ab-res2-tsccf   Successfully assigned res2/nfs-restore-pvc-2d532ab-res2-tsccf to pwx-ocp-208-237-ggd58-worker-vxjtw
93s         Normal    AddedInterface         pod/nfs-restore-pvc-2d532ab-res2-tsccf   Add eth0 [10.131.1.178/23] from openshift-sdn
93s         Normal    Pulling                pod/nfs-restore-pvc-2d532ab-res2-tsccf   Pulling image "openstorage/nfsexecutor:1.2.10"
88s         Normal    Pulled                 pod/nfs-restore-pvc-2d532ab-res2-tsccf   Successfully pulled image "openstorage/nfsexecutor:1.2.10" in 5.049402435s (5.04941885s including waiting)
88s         Normal    Created                pod/nfs-restore-pvc-2d532ab-res2-tsccf   Created container nfsexecutor
88s         Normal    Started                pod/nfs-restore-pvc-2d532ab-res2-tsccf   Started container nfsexecutor
95s         Normal    SuccessfulCreate       job/nfs-restore-pvc-2d532ab-res2         Created pod: nfs-restore-pvc-2d532ab-res2-tsccf
47s         Normal    Completed              job/nfs-restore-pvc-2d532ab-res2         Job completed
➜  ~

With fix, the PVC Is bounded as the label selector is removed:

➜  ~ kubectl get pvc -n res1
NAME      STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS                AGE
nfs-pvc   Bound    pvc-33f44822-01d0-4a6e-ac88-719230464d06   1Gi        RWX            ocs-storagecluster-cephfs   88m
➜  ~ kubectl get pvc -n res1 -oyaml
apiVersion: v1
items:
- apiVersion: v1
  kind: PersistentVolumeClaim
  metadata:
    annotations:
      kubectl.kubernetes.io/last-applied-configuration: |
        {"apiVersion":"v1","kind":"PersistentVolumeClaim","metadata":{"annotations":{},"name":"nfs-pvc","namespace":"nfs-test"},"spec":{"accessModes":["ReadWriteMany"],"resources":{"requests":{"storage":"1Gi"}},"selector":{"matchLabels":{"app":"test"}}}}
      pv.kubernetes.io/bind-completed: "yes"
      pv.kubernetes.io/bound-by-controller: "yes"
      stork.libopenstorage.org/created-by: stork.libopenstorage.org/kdmp
      volume.beta.kubernetes.io/storage-provisioner: openshift-storage.cephfs.csi.ceph.com
      volume.kubernetes.io/storage-provisioner: openshift-storage.cephfs.csi.ceph.com
    creationTimestamp: "2024-02-19T08:31:25Z"
    finalizers:
    - kubernetes.io/pvc-protection
    name: nfs-pvc
    namespace: res1
    resourceVersion: "3049210"
    uid: 33f44822-01d0-4a6e-ac88-719230464d06
  spec:
    accessModes:
    - ReadWriteMany
    resources:
      requests:
        storage: 1Gi
    storageClassName: ocs-storagecluster-cephfs
    volumeMode: Filesystem
    volumeName: pvc-33f44822-01d0-4a6e-ac88-719230464d06
  status:
    accessModes:
    - ReadWriteMany
    capacity:
      storage: 1Gi
    phase: Bound
kind: List
metadata:
  resourceVersion: ""
  selfLink: ""
➜  ~

@github-actions GitHub Actions
Copy link

OSS Scan Results:

Title Severity Package Name CVEs Fix version Introduced
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/objectstore@#636d43cc74ca', 'github.com/libopenstorage/stork/pkg/objectstore/google@#636d43cc74ca', 'gocloud.dev/blob/[email protected]', 'cloud.google.com/go/iam/credentials/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#636d43cc74ca', 'google.golang.org/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#636d43cc74ca', 'google.golang.org/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'github.com/golang/protobuf/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/applicationmanager/controllers@#636d43cc74ca', 'github.com/libopenstorage/stork/pkg/objectstore@#636d43cc74ca', 'github.com/libopenstorage/stork/pkg/objectstore/google@#636d43cc74ca', 'gocloud.dev/blob/[email protected]', 'cloud.google.com/go/iam/credentials/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/snapshotter@#636d43cc74ca', 'github.com/libopenstorage/stork/pkg/objectstore@#636d43cc74ca', 'github.com/libopenstorage/stork/pkg/objectstore/google@#636d43cc74ca', 'gocloud.dev/blob/[email protected]', 'cloud.google.com/go/iam/credentials/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/portworx/pxc/pkg/[email protected]', 'github.com/libopenstorage/openstorage-sdk-clients/sdk/[email protected]', 'google.golang.org/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/portworx/pxc/pkg/[email protected]', 'github.com/libopenstorage/openstorage-sdk-clients/sdk/[email protected]', 'google.golang.org/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'github.com/golang/protobuf/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume@#636d43cc74ca', 'sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/pkg/[email protected]', 'github.com/GoogleCloudPlatform/k8s-cloud-provider/pkg/cloud/meta@#f11817397a1b', 'google.golang.org/api/compute/[email protected]', 'google.golang.org/api/internal/[email protected]', 'github.com/googleapis/gax-go/v2/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/gcp@#636d43cc74ca', 'sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/pkg/[email protected]', 'github.com/GoogleCloudPlatform/k8s-cloud-provider/pkg/cloud/meta@#f11817397a1b', 'google.golang.org/api/compute/[email protected]', 'google.golang.org/api/internal/[email protected]', 'github.com/googleapis/gax-go/v2/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume@#636d43cc74ca', 'sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/pkg/[email protected]', 'github.com/GoogleCloudPlatform/k8s-cloud-provider/pkg/cloud/meta@#f11817397a1b', 'google.golang.org/api/compute/[email protected]', 'google.golang.org/api/internal/[email protected]', 'github.com/googleapis/gax-go/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/gcp@#636d43cc74ca', 'sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/pkg/[email protected]', 'github.com/GoogleCloudPlatform/k8s-cloud-provider/pkg/cloud/meta@#f11817397a1b', 'google.golang.org/api/compute/[email protected]', 'google.golang.org/api/internal/[email protected]', 'github.com/googleapis/gax-go/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/csi@#636d43cc74ca', 'github.com/libopenstorage/stork/pkg/snapshotter@#636d43cc74ca', 'github.com/libopenstorage/stork/pkg/objectstore@#636d43cc74ca', 'github.com/libopenstorage/stork/pkg/objectstore/google@#636d43cc74ca', 'gocloud.dev/blob/[email protected]', 'cloud.google.com/go/iam/credentials/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#636d43cc74ca', 'github.com/libopenstorage/stork/pkg/applicationmanager/controllers@#636d43cc74ca', 'github.com/libopenstorage/stork/pkg/objectstore@#636d43cc74ca', 'github.com/libopenstorage/stork/pkg/objectstore/google@#636d43cc74ca', 'gocloud.dev/blob/[email protected]', 'cloud.google.com/go/iam/credentials/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/portworx/pxc/pkg/[email protected]', 'github.com/portworx/pxc/pkg/[email protected]', 'github.com/libopenstorage/openstorage-sdk-clients/sdk/[email protected]', 'google.golang.org/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/portworx/pxc/pkg/[email protected]', 'github.com/portworx/pxc/pkg/[email protected]', 'github.com/libopenstorage/openstorage-sdk-clients/sdk/[email protected]', 'google.golang.org/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/portworx/pxc/pkg/[email protected]', 'github.com/portworx/pxc/pkg/[email protected]', 'github.com/libopenstorage/openstorage-sdk-clients/sdk/[email protected]', 'google.golang.org/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'github.com/golang/protobuf/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/portworx/pxc/pkg/[email protected]', 'github.com/portworx/pxc/pkg/[email protected]', 'github.com/libopenstorage/openstorage-sdk-clients/sdk/[email protected]', 'google.golang.org/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'github.com/golang/protobuf/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/aws@#636d43cc74ca', 'github.com/libopenstorage/stork/drivers/volume@#636d43cc74ca', 'sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/pkg/[email protected]', 'github.com/GoogleCloudPlatform/k8s-cloud-provider/pkg/cloud/meta@#f11817397a1b', 'google.golang.org/api/compute/[email protected]', 'google.golang.org/api/internal/[email protected]', 'github.com/googleapis/gax-go/v2/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/azure@#636d43cc74ca', 'github.com/libopenstorage/stork/drivers/volume@#636d43cc74ca', 'sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/pkg/[email protected]', 'github.com/GoogleCloudPlatform/k8s-cloud-provider/pkg/cloud/meta@#f11817397a1b', 'google.golang.org/api/compute/[email protected]', 'google.golang.org/api/internal/[email protected]', 'github.com/googleapis/gax-go/v2/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/kdmp@#636d43cc74ca', 'github.com/libopenstorage/stork/drivers/volume@#636d43cc74ca', 'sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/pkg/[email protected]', 'github.com/GoogleCloudPlatform/k8s-cloud-provider/pkg/cloud/meta@#f11817397a1b', 'google.golang.org/api/compute/[email protected]', 'google.golang.org/api/internal/[email protected]', 'github.com/googleapis/gax-go/v2/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/resourcecollector@#636d43cc74ca', 'github.com/libopenstorage/stork/drivers/volume@#636d43cc74ca', 'sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/pkg/[email protected]', 'github.com/GoogleCloudPlatform/k8s-cloud-provider/pkg/cloud/meta@#f11817397a1b', 'google.golang.org/api/compute/[email protected]', 'google.golang.org/api/internal/[email protected]', 'github.com/googleapis/gax-go/v2/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/aws@#636d43cc74ca', 'github.com/libopenstorage/stork/drivers/volume@#636d43cc74ca', 'sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/pkg/[email protected]', 'github.com/GoogleCloudPlatform/k8s-cloud-provider/pkg/cloud/meta@#f11817397a1b', 'google.golang.org/api/compute/[email protected]', 'google.golang.org/api/internal/[email protected]', 'github.com/googleapis/gax-go/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/azure@#636d43cc74ca', 'github.com/libopenstorage/stork/drivers/volume@#636d43cc74ca', 'sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/pkg/[email protected]', 'github.com/GoogleCloudPlatform/k8s-cloud-provider/pkg/cloud/meta@#f11817397a1b', 'google.golang.org/api/compute/[email protected]', 'google.golang.org/api/internal/[email protected]', 'github.com/googleapis/gax-go/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/kdmp@#636d43cc74ca', 'github.com/libopenstorage/stork/drivers/volume@#636d43cc74ca', 'sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/pkg/[email protected]', 'github.com/GoogleCloudPlatform/k8s-cloud-provider/pkg/cloud/meta@#f11817397a1b', 'google.golang.org/api/compute/[email protected]', 'google.golang.org/api/internal/[email protected]', 'github.com/googleapis/gax-go/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/resourcecollector@#636d43cc74ca', 'github.com/libopenstorage/stork/drivers/volume@#636d43cc74ca', 'sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/pkg/[email protected]', 'github.com/GoogleCloudPlatform/k8s-cloud-provider/pkg/cloud/meta@#f11817397a1b', 'google.golang.org/api/compute/[email protected]', 'google.golang.org/api/internal/[email protected]', 'github.com/googleapis/gax-go/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/applicationmanager/controllers@#636d43cc74ca', 'github.com/libopenstorage/stork/drivers/volume/kdmp@#636d43cc74ca', 'github.com/libopenstorage/stork/drivers/volume@#636d43cc74ca', 'sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/pkg/[email protected]', 'github.com/GoogleCloudPlatform/k8s-cloud-provider/pkg/cloud/meta@#f11817397a1b', 'google.golang.org/api/compute/[email protected]', 'google.golang.org/api/internal/[email protected]', 'github.com/googleapis/gax-go/v2/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#636d43cc74ca', 'github.com/libopenstorage/stork/pkg/snapshot/controllers@#636d43cc74ca', 'github.com/libopenstorage/stork/drivers/volume@#636d43cc74ca', 'sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/pkg/[email protected]', 'github.com/GoogleCloudPlatform/k8s-cloud-provider/pkg/cloud/meta@#f11817397a1b', 'google.golang.org/api/compute/[email protected]', 'google.golang.org/api/internal/[email protected]', 'github.com/googleapis/gax-go/v2/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/applicationmanager/controllers@#636d43cc74ca', 'github.com/libopenstorage/stork/drivers/volume/kdmp@#636d43cc74ca', 'github.com/libopenstorage/stork/drivers/volume@#636d43cc74ca', 'sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/pkg/[email protected]', 'github.com/GoogleCloudPlatform/k8s-cloud-provider/pkg/cloud/meta@#f11817397a1b', 'google.golang.org/api/compute/[email protected]', 'google.golang.org/api/internal/[email protected]', 'github.com/googleapis/gax-go/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#636d43cc74ca', 'github.com/libopenstorage/stork/pkg/snapshot/controllers@#636d43cc74ca', 'github.com/libopenstorage/stork/drivers/volume@#636d43cc74ca', 'sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/pkg/[email protected]', 'github.com/GoogleCloudPlatform/k8s-cloud-provider/pkg/cloud/meta@#f11817397a1b', 'google.golang.org/api/compute/[email protected]', 'google.golang.org/api/internal/[email protected]', 'github.com/googleapis/gax-go/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/csi@#636d43cc74ca', 'github.com/libopenstorage/stork/pkg/applicationmanager/controllers@#636d43cc74ca', 'github.com/libopenstorage/stork/drivers/volume/kdmp@#636d43cc74ca', 'github.com/libopenstorage/stork/drivers/volume@#636d43cc74ca', 'sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/pkg/[email protected]', 'github.com/GoogleCloudPlatform/k8s-cloud-provider/pkg/cloud/meta@#f11817397a1b', 'google.golang.org/api/compute/[email protected]', 'google.golang.org/api/internal/[email protected]', 'github.com/googleapis/gax-go/v2/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/csi@#636d43cc74ca', 'github.com/libopenstorage/stork/pkg/applicationmanager/controllers@#636d43cc74ca', 'github.com/libopenstorage/stork/drivers/volume/kdmp@#636d43cc74ca', 'github.com/libopenstorage/stork/drivers/volume@#636d43cc74ca', 'sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/pkg/[email protected]', 'github.com/GoogleCloudPlatform/k8s-cloud-provider/pkg/cloud/meta@#f11817397a1b', 'google.golang.org/api/compute/[email protected]', 'google.golang.org/api/internal/[email protected]', 'github.com/googleapis/gax-go/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume@#636d43cc74ca', 'sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/pkg/[email protected]', 'github.com/GoogleCloudPlatform/k8s-cloud-provider/pkg/cloud/meta@#f11817397a1b', 'google.golang.org/api/compute/[email protected]', 'google.golang.org/api/transport/[email protected]', 'google.golang.org/api/[email protected]', 'google.golang.org/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/gcp@#636d43cc74ca', 'sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/pkg/[email protected]', 'github.com/GoogleCloudPlatform/k8s-cloud-provider/pkg/cloud/meta@#f11817397a1b', 'google.golang.org/api/compute/[email protected]', 'google.golang.org/api/transport/[email protected]', 'google.golang.org/api/[email protected]', 'google.golang.org/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume@#636d43cc74ca', 'sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/pkg/[email protected]', 'github.com/GoogleCloudPlatform/k8s-cloud-provider/pkg/cloud/meta@#f11817397a1b', 'google.golang.org/api/compute/[email protected]', 'google.golang.org/api/transport/[email protected]', 'google.golang.org/api/[email protected]', 'google.golang.org/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'github.com/golang/protobuf/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/gcp@#636d43cc74ca', 'sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/pkg/[email protected]', 'github.com/GoogleCloudPlatform/k8s-cloud-provider/pkg/cloud/meta@#f11817397a1b', 'google.golang.org/api/compute/[email protected]', 'google.golang.org/api/transport/[email protected]', 'google.golang.org/api/[email protected]', 'google.golang.org/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'github.com/golang/protobuf/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/aws@#636d43cc74ca', 'github.com/libopenstorage/stork/drivers/volume@#636d43cc74ca', 'sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/pkg/[email protected]', 'github.com/GoogleCloudPlatform/k8s-cloud-provider/pkg/cloud/meta@#f11817397a1b', 'google.golang.org/api/compute/[email protected]', 'google.golang.org/api/transport/[email protected]', 'google.golang.org/api/[email protected]', 'google.golang.org/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/azure@#636d43cc74ca', 'github.com/libopenstorage/stork/drivers/volume@#636d43cc74ca', 'sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/pkg/[email protected]', 'github.com/GoogleCloudPlatform/k8s-cloud-provider/pkg/cloud/meta@#f11817397a1b', 'google.golang.org/api/compute/[email protected]', 'google.golang.org/api/transport/[email protected]', 'google.golang.org/api/[email protected]', 'google.golang.org/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/kdmp@#636d43cc74ca', 'github.com/libopenstorage/stork/drivers/volume@#636d43cc74ca', 'sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/pkg/[email protected]', 'github.com/GoogleCloudPlatform/k8s-cloud-provider/pkg/cloud/meta@#f11817397a1b', 'google.golang.org/api/compute/[email protected]', 'google.golang.org/api/transport/[email protected]', 'google.golang.org/api/[email protected]', 'google.golang.org/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/resourcecollector@#636d43cc74ca', 'github.com/libopenstorage/stork/drivers/volume@#636d43cc74ca', 'sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/pkg/[email protected]', 'github.com/GoogleCloudPlatform/k8s-cloud-provider/pkg/cloud/meta@#f11817397a1b', 'google.golang.org/api/compute/[email protected]', 'google.golang.org/api/transport/[email protected]', 'google.golang.org/api/[email protected]', 'google.golang.org/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/aws@#636d43cc74ca', 'github.com/libopenstorage/stork/drivers/volume@#636d43cc74ca', 'sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/pkg/[email protected]', 'github.com/GoogleCloudPlatform/k8s-cloud-provider/pkg/cloud/meta@#f11817397a1b', 'google.golang.org/api/compute/[email protected]', 'google.golang.org/api/transport/[email protected]', 'google.golang.org/api/[email protected]', 'google.golang.org/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'github.com/golang/protobuf/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/azure@#636d43cc74ca', 'github.com/libopenstorage/stork/drivers/volume@#636d43cc74ca', 'sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/pkg/[email protected]', 'github.com/GoogleCloudPlatform/k8s-cloud-provider/pkg/cloud/meta@#f11817397a1b', 'google.golang.org/api/compute/[email protected]', 'google.golang.org/api/transport/[email protected]', 'google.golang.org/api/[email protected]', 'google.golang.org/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'github.com/golang/protobuf/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/kdmp@#636d43cc74ca', 'github.com/libopenstorage/stork/drivers/volume@#636d43cc74ca', 'sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/pkg/[email protected]', 'github.com/GoogleCloudPlatform/k8s-cloud-provider/pkg/cloud/meta@#f11817397a1b', 'google.golang.org/api/compute/[email protected]', 'google.golang.org/api/transport/[email protected]', 'google.golang.org/api/[email protected]', 'google.golang.org/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'github.com/golang/protobuf/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/resourcecollector@#636d43cc74ca', 'github.com/libopenstorage/stork/drivers/volume@#636d43cc74ca', 'sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/pkg/[email protected]', 'github.com/GoogleCloudPlatform/k8s-cloud-provider/pkg/cloud/meta@#f11817397a1b', 'google.golang.org/api/compute/[email protected]', 'google.golang.org/api/transport/[email protected]', 'google.golang.org/api/[email protected]', 'google.golang.org/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'github.com/golang/protobuf/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/applicationmanager/controllers@#636d43cc74ca', 'github.com/libopenstorage/stork/drivers/volume/kdmp@#636d43cc74ca', 'github.com/libopenstorage/stork/drivers/volume@#636d43cc74ca', 'sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/pkg/[email protected]', 'github.com/GoogleCloudPlatform/k8s-cloud-provider/pkg/cloud/meta@#f11817397a1b', 'google.golang.org/api/compute/[email protected]', 'google.golang.org/api/transport/[email protected]', 'google.golang.org/api/[email protected]', 'google.golang.org/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/applicationmanager/controllers@#636d43cc74ca', 'github.com/libopenstorage/stork/drivers/volume/kdmp@#636d43cc74ca', 'github.com/libopenstorage/stork/drivers/volume@#636d43cc74ca', 'sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/pkg/[email protected]', 'github.com/GoogleCloudPlatform/k8s-cloud-provider/pkg/cloud/meta@#f11817397a1b', 'google.golang.org/api/compute/[email protected]', 'google.golang.org/api/transport/[email protected]', 'google.golang.org/api/[email protected]', 'google.golang.org/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'github.com/golang/protobuf/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/csi@#636d43cc74ca', 'github.com/libopenstorage/stork/pkg/applicationmanager/controllers@#636d43cc74ca', 'github.com/libopenstorage/stork/drivers/volume/kdmp@#636d43cc74ca', 'github.com/libopenstorage/stork/drivers/volume@#636d43cc74ca', 'sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/pkg/[email protected]', 'github.com/GoogleCloudPlatform/k8s-cloud-provider/pkg/cloud/meta@#f11817397a1b', 'google.golang.org/api/compute/[email protected]', 'google.golang.org/api/transport/[email protected]', 'google.golang.org/api/[email protected]', 'google.golang.org/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/csi@#636d43cc74ca', 'github.com/libopenstorage/stork/pkg/applicationmanager/controllers@#636d43cc74ca', 'github.com/libopenstorage/stork/drivers/volume/kdmp@#636d43cc74ca', 'github.com/libopenstorage/stork/drivers/volume@#636d43cc74ca', 'sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/pkg/[email protected]', 'github.com/GoogleCloudPlatform/k8s-cloud-provider/pkg/cloud/meta@#f11817397a1b', 'google.golang.org/api/compute/[email protected]', 'google.golang.org/api/transport/[email protected]', 'google.golang.org/api/[email protected]', 'google.golang.org/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'github.com/golang/protobuf/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']

Total issues: 47

@github-actions GitHub Actions
Copy link

License Evaluation Results:

Title Package Name Package Version Severity License Info Introduced
MPL-2.0 license github.com/hashicorp/errwrap 1.1.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#636d43cc74ca', 'github.com/libopenstorage/stork/pkg/snapshot/controllers@#636d43cc74ca', 'github.com/hashicorp/[email protected]', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-multierror 1.1.1 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#636d43cc74ca', 'github.com/libopenstorage/stork/pkg/snapshot/controllers@#636d43cc74ca', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/version@#636d43cc74ca', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#636d43cc74ca', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/k8sutils@#636d43cc74ca', 'github.com/libopenstorage/stork/pkg/version@#636d43cc74ca', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/resourcecollector@#636d43cc74ca', 'github.com/libopenstorage/stork/pkg/version@#636d43cc74ca', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/csi@#636d43cc74ca', 'github.com/libopenstorage/stork/pkg/version@#636d43cc74ca', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume@#636d43cc74ca', 'github.com/libopenstorage/stork/pkg/k8sutils@#636d43cc74ca', 'github.com/libopenstorage/stork/pkg/version@#636d43cc74ca', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/aws@#636d43cc74ca', 'github.com/libopenstorage/stork/pkg/k8sutils@#636d43cc74ca', 'github.com/libopenstorage/stork/pkg/version@#636d43cc74ca', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/azure@#636d43cc74ca', 'github.com/libopenstorage/stork/pkg/k8sutils@#636d43cc74ca', 'github.com/libopenstorage/stork/pkg/version@#636d43cc74ca', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/kdmp@#636d43cc74ca', 'github.com/libopenstorage/stork/pkg/k8sutils@#636d43cc74ca', 'github.com/libopenstorage/stork/pkg/version@#636d43cc74ca', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/gcp@#636d43cc74ca', 'github.com/libopenstorage/stork/pkg/k8sutils@#636d43cc74ca', 'github.com/libopenstorage/stork/pkg/version@#636d43cc74ca', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#636d43cc74ca', 'github.com/libopenstorage/stork/pkg/snapshot/controllers@#636d43cc74ca', 'github.com/libopenstorage/stork/pkg/version@#636d43cc74ca', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/snapshotter@#636d43cc74ca', 'github.com/libopenstorage/stork/pkg/k8sutils@#636d43cc74ca', 'github.com/libopenstorage/stork/pkg/version@#636d43cc74ca', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/applicationmanager/controllers@#636d43cc74ca', 'github.com/libopenstorage/stork/drivers/volume/kdmp@#636d43cc74ca', 'github.com/libopenstorage/stork/pkg/k8sutils@#636d43cc74ca', 'github.com/libopenstorage/stork/pkg/version@#636d43cc74ca', 'github.com/hashicorp/[email protected]']
Unknown license github.com/rancher/wrangler/pkg/name 1.1.0 high Unknown ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/applicationmanager/controllers@#636d43cc74ca', 'github.com/libopenstorage/stork/pkg/platform/rancher@#636d43cc74ca', 'github.com/rancher/rancher/pkg/client/generated/management/v3@#a67566517525', 'github.com/rancher/norman/types@#275a3e921940', 'github.com/rancher/wrangler/pkg/[email protected]']
Unknown license github.com/rancher/wrangler/pkg/name 1.1.0 high Unknown ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/csi@#636d43cc74ca', 'github.com/libopenstorage/stork/pkg/applicationmanager/controllers@#636d43cc74ca', 'github.com/libopenstorage/stork/pkg/platform/rancher@#636d43cc74ca', 'github.com/rancher/rancher/pkg/client/generated/management/v3@#a67566517525', 'github.com/rancher/norman/types@#275a3e921940', 'github.com/rancher/wrangler/pkg/[email protected]']
Unknown license github.com/rancher/wrangler/pkg/name 1.1.0 high Unknown ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#636d43cc74ca', 'github.com/libopenstorage/stork/pkg/applicationmanager/controllers@#636d43cc74ca', 'github.com/libopenstorage/stork/pkg/platform/rancher@#636d43cc74ca', 'github.com/rancher/rancher/pkg/client/generated/management/v3@#a67566517525', 'github.com/rancher/norman/types@#275a3e921940', 'github.com/rancher/wrangler/pkg/[email protected]']

Total License Issues: 19

lalat-das
lalat-das approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@lalat-das lalat-das left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

prashanthpx
prashanthpx reviewed Feb 19, 2024
View reviewed changes
pkg/controllers/dataexport/reconcile.go
@@ -1737,6 +1737,11 @@ func (c *Controller) restoreSnapshot(ctx context.Context, snapshotDriver snapsho

func (c *Controller) createPVC(dataExport *kdmpapi.DataExport) (*corev1.PersistentVolumeClaim, error) {
pvc := dataExport.Status.RestorePVC
if pvc.Spec.Selector != nil {
// Remove the labelselector, as it is a dynamic provisioning.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a case where PVC is referenced to a PV not by name and based on label selector how would this work?
Eg
PV spec

apiVersion: v1
kind: PersistentVolume
metadata:
  name: test-pv
  labels:
    volume-type: ssd

PVC spec as follows which doesn't specify volumeMount but looks for a PV to match the label selector.

apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: test-pvc
spec:
  accessModes:
    - ReadWriteOnce
  resources:
    requests:
      storage: 5Gi
  selector:
    matchLabels:
      volume-type: ssd

@siva-portworx siva-portworx merged commit 4ce8192 into master Feb 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prashanthpx prashanthpx prashanthpx approved these changes

@lalat-das lalat-das lalat-das approved these changes

@vikasit12 vikasit12 Awaiting requested review from vikasit12

@px-kesavan px-kesavan Awaiting requested review from px-kesavan

@pallav-px pallav-px Awaiting requested review from pallav-px

@vsundarraj-px vsundarraj-px Awaiting requested review from vsundarraj-px

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@siva-portworx @lalat-das @prashanthpx