Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PB-6853: travis changes to push docker images for private branches #376

Closed
wants to merge 1 commit into from
Closed

PB-6853: travis changes to push docker images for private branches #376

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ script:
elif [ "${TRAVIS_BRANCH}" == "master" ]; then
export DOCKER_IMAGE_TAG=master-latest
else
export RELEASE_VER=`git rev-parse --short HEAD`
export DOCKER_IMAGE_TAG=${TRAVIS_BRANCH}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do the same for px-backup as well @dbinnal-px

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, Will check with @prashanthpx

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking back, the reason they had git sha was a docker image build was always available for every commit we make and is consumable. When this changes to branch, then there are possibility that more than one people working on the same branch will have images overwritten. I think then lets keep the change as is before.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing the PR

fi
make all &&
if [ "${TRAVIS_PULL_REQUEST}" == "false" ]; then
Expand Down
Loading