PB-8410 Fix global variable reset issue #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vsundarraj-px <[email protected]>
vsundarraj-px
requested review from
siva-portworx,
vikasit12,
px-kesavan and
aks-px
|
License Evaluation Results:
Total License Issues: 17 |
vikasit12
approved these changes
Nov 26, 2024
|
Unit test result of default value set when nothing is set on configMap |
aks-px
reviewed
Nov 26, 2024
| if err != nil { | ||
| // we should never reach here. | ||
| logrus.Debugf("%v: failed to parse the failure timeout set %v: %v", fn, JobFailureRetryTimeout, err) | ||
| logrus.Debugf("%v: error parsing %v value. Retaining current setting %v: %v", fn, PxbJobFailureRetryTimeoutKey, JobFailureRetryTimeout, err) |
There was a problem hiding this comment.
Should we need to initialize duration to some value here? otherwise if this is hit JobFailureRetryTimeout might be set to 0 in next line
aks-px
approved these changes
Nov 26, 2024
dbinnal-px
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This addresses regression caused due to last commit for PB-8410 where global variable was never getting set due to local shodowing of the variable.
Which issue(s) this PR fixes (optional)
Closes # PB-8410
Special notes for your reviewer:
The main culprit code is at line 1251. Rest of the change is to make debugging easier.
Unit testing
Retry code kicking in with 10m timeout set
Debug code showing timeOut of 10m getting reflected
Screen shot showing pod successfully running even after mount failure timeOut elapsing. This is to ensure that timeOut is only for failure and not for successfully running job.