-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pb-6810: Added resource group name to S3Config of the backuplocation object #244
Conversation
OSS Scan Results:
Total issues: 43 |
License Evaluation Results:
Total License Issues: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, other than that optional related comment.
pkg/apis/v1/api.proto
Outdated
@@ -165,6 +165,9 @@ message S3Config { | |||
// Azure environment type | |||
// Currently supporting only AZURE_GLOBAL and AZURE_CHINA | |||
AzureEnvironmentType azure_environment = 7; | |||
// Azure resource group name. | |||
// This is needed in the case of azure immutable bucket to get the retention period |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure to add (optional) in the comment if it is an optional argument in BL related ops
OSS Scan Results:
Total issues: 43 |
License Evaluation Results:
Total License Issues: 0 |
03b25e4
to
22ff162
Compare
OSS Scan Results:
Total issues: 43 |
License Evaluation Results:
Total License Issues: 0 |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional)
Closes # pb-6810
Special notes for your reviewer:
N.A
To azure SDK call need reource group name to get the retention period for the locked bucket.
We will be getting this from user during the backuplocation creation.