pb-6810: Added resource group name to S3Config of the backuplocation object #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siva-portworx
assigned lalat-das, prashanthpx, vikasit12, prabhu-px, px-kesavan and vsundarraj-px
|
OSS Scan Results:
Total issues: 43 |
|
License Evaluation Results:
Total License Issues: 0 |
lalat-das
approved these changes
May 10, 2024
pkg/apis/v1/api.proto
Outdated
| @@ -165,6 +165,9 @@ message S3Config { | |||
| // Azure environment type | |||
| // Currently supporting only AZURE_GLOBAL and AZURE_CHINA | |||
| AzureEnvironmentType azure_environment = 7; | |||
| // Azure resource group name. | |||
| // This is needed in the case of azure immutable bucket to get the retention period | |||
There was a problem hiding this comment.
Please make sure to add (optional) in the comment if it is an optional argument in BL related ops
|
OSS Scan Results:
Total issues: 43 |
|
License Evaluation Results:
Total License Issues: 0 |
siva-portworx
force-pushed
the
pb-6810-final
branch
from
03b25e4
to
22ff162
Compare
|
OSS Scan Results:
Total issues: 43 |
|
License Evaluation Results:
Total License Issues: 0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional)
Closes # pb-6810
Special notes for your reviewer:
N.A
To azure SDK call need reource group name to get the retention period for the locked bucket.
We will be getting this from user during the backuplocation creation.