Fix deployment name in backup config #2384
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atrivedi-px
requested review from
aravindranath14,
Madanagopal19 and
jkagliwal-px
Madanagopal19
requested changes
Apr 19, 2024
| @@ -139,6 +139,16 @@ func (wfDataService *WorkflowDataService) ValidatePdsDataServiceDeployments(depl | |||
| return nil | |||
| } | |||
|
|
|||
| // GetDeploymentPodName gets the pod name for the deployment | |||
| func (wfDataService *WorkflowDataService) GetDeploymentPodName(deploymentId string) (string, error) { | |||
There was a problem hiding this comment.
This method is not requrired, line no #114 returns the deploymentPod Name and deployment
| @@ -149,7 +159,12 @@ func (wfDataService *WorkflowDataService) GetDsDeploymentResources(deployment ma | |||
| deploymentName, deploymentId := GetDeploymentNameAndId(deployment) | |||
| log.Debugf("deployment Name [%s] and Id [%s]", deploymentName, deploymentId) | |||
|
|
|||
| dbConfig, err = dslibs.GetDeploymentConfigurations(namespace, dataServiceName, deploymentName) | |||
| podName, err := wfDataService.GetDeploymentPodName(deploymentId) | |||
There was a problem hiding this comment.
can we directly call _, podName, err := dslibs.GetDeployment(deploymentId) instead of having a seperate workflow only to get GetDeploymentPodName
|
Changes are added as part of #2390 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fix deployment name in backup config
Which issue(s) this PR fixes (optional)
Closes #DS-9250
Special notes for your reviewer:
https://jenkins.pwx.dev.purestorage.com/job/PDS/job/pds2.0-byoc-branch-build-test/434/console