Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated target frameworks #110

Merged
merged 2 commits into from
Nov 15, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-and-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
with:
dotnet-version: |
6.0.x
7.0.x
8.0.x
- name: Restore dependencies
run: dotnet restore
- name: Build
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/code-style.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
with:
dotnet-version: |
6.0.x
7.0.x
8.0.x
- name: Restore tools
run: dotnet tool restore
- name: Check code style
Expand Down
12 changes: 10 additions & 2 deletions .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,19 @@ jobs:
steps:
- name: Checkout repository
uses: actions/checkout@v4
- name: Setup .NET
uses: actions/setup-dotnet@v3
with:
dotnet-version: |
6.0.x
8.0.x
- name: Initialize CodeQL
uses: github/codeql-action/init@v2
with:
languages: ${{ matrix.language }}
- name: Autobuild
uses: github/codeql-action/autobuild@v2
- name: Restore dependencies
run: dotnet restore
- name: Build
run: dotnet build --no-restore
- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v2
2 changes: 1 addition & 1 deletion .github/workflows/publish-nuget.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
with:
dotnet-version: |
6.0.x
7.0.x
8.0.x
- name: Restore dependencies
run: dotnet restore
- name: Build
Expand Down
2 changes: 1 addition & 1 deletion Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<Authors>Vladimir Portyanikhin</Authors>
<Copyright>Copyright (c) Vladimir Portyanikhin 2021</Copyright>
<ImplicitUsings>enable</ImplicitUsings>
<LangVersion>11.0</LangVersion>
<LangVersion>12.0</LangVersion>
<Nullable>enable</Nullable>
<PackageLicenseExpression>MIT</PackageLicenseExpression>
<PackageProjectUrl>https://github.com/portyanikhin/VCRC</PackageProjectUrl>
Expand Down
2 changes: 1 addition & 1 deletion src/Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
<PackageIcon>icon.png</PackageIcon>
<PackageReadmeFile>NuGet.md</PackageReadmeFile>
<TargetFrameworks>netstandard2.0;netstandard2.1;net7.0</TargetFrameworks>
<TargetFrameworks>netstandard2.0;netstandard2.1;net8.0</TargetFrameworks>
</PropertyGroup>

<ItemGroup>
Expand Down
8 changes: 2 additions & 6 deletions src/VCRC/Abstract/AbstractTwoStageVCRC.cs
Original file line number Diff line number Diff line change
@@ -1,13 +1,9 @@
namespace VCRC;

/// <summary>
/// Two-stage vapor-compression refrigeration cycle.
/// </summary>
/// <inheritdoc cref="ITwoStageVCRC"/>
public abstract class AbstractTwoStageVCRC : AbstractVCRC, ITwoStageVCRC
{
/// <summary>
/// Two-stage vapor-compression refrigeration cycle.
/// </summary>
/// <inheritdoc cref="AbstractTwoStageVCRC"/>
/// <param name="evaporator">Evaporator.</param>
/// <param name="compressor">Compressor.</param>
/// <param name="heatReleaser">Condenser or gas cooler.</param>
Expand Down
8 changes: 2 additions & 6 deletions src/VCRC/Abstract/AbstractVCRC.cs
Original file line number Diff line number Diff line change
@@ -1,13 +1,9 @@
namespace VCRC;

/// <summary>
/// Vapor-compression refrigeration cycle.
/// </summary>
/// <inheritdoc cref="IVCRC"/>
public abstract class AbstractVCRC : IVCRC
{
/// <summary>
/// Vapor-compression refrigeration cycle.
/// </summary>
/// <inheritdoc cref="AbstractVCRC"/>
/// <param name="evaporator">Evaporator.</param>
/// <param name="compressor">Compressor.</param>
/// <param name="heatReleaser">Condenser or gas cooler.</param>
Expand Down
8 changes: 2 additions & 6 deletions src/VCRC/Components/Compressor.cs
Original file line number Diff line number Diff line change
@@ -1,13 +1,9 @@
namespace VCRC;

/// <summary>
/// Compressor.
/// </summary>
/// <inheritdoc cref="ICompressor"/>
public record Compressor : ICompressor
{
/// <summary>
/// Compressor.
/// </summary>
/// <inheritdoc cref="Compressor"/>
/// <param name="efficiency">Isentropic efficiency.</param>
/// <exception cref="ValidationException">
/// Isentropic efficiency of the compressor should be in (0;100) %!
Expand Down
8 changes: 2 additions & 6 deletions src/VCRC/Components/Condenser.cs
Original file line number Diff line number Diff line change
@@ -1,13 +1,9 @@
namespace VCRC;

/// <summary>
/// Condenser.
/// </summary>
/// <inheritdoc cref="ICondenser"/>
public record Condenser : ICondenser
{
/// <summary>
/// Condenser.
/// </summary>
/// <inheritdoc cref="Condenser"/>
/// <param name="refrigerantName">Selected refrigerant name.</param>
/// <param name="temperature">Condensing temperature (bubble point).</param>
/// <param name="subcooling">Subcooling.</param>
Expand Down
8 changes: 2 additions & 6 deletions src/VCRC/Components/Economizer.cs
Original file line number Diff line number Diff line change
@@ -1,13 +1,9 @@
namespace VCRC;

/// <summary>
/// Economizer.
/// </summary>
/// <inheritdoc cref="IEconomizer"/>
public record Economizer : EconomizerWithTPI, IEconomizer
{
/// <summary>
/// Economizer.
/// </summary>
/// <inheritdoc cref="Economizer"/>
/// <param name="temperatureDifference">
/// Temperature difference at the "cold" side.
/// </param>
Expand Down
4 changes: 1 addition & 3 deletions src/VCRC/Components/EconomizerWithTPI.cs
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,7 @@
/// </summary>
public record EconomizerWithTPI : IAuxiliaryHeatExchanger
{
/// <summary>
/// Economizer with two-phase injection into the compressor.
/// </summary>
/// <inheritdoc cref="EconomizerWithTPI"/>
/// <param name="temperatureDifference">
/// Temperature difference at the "cold" side.
/// </param>
Expand Down
12 changes: 3 additions & 9 deletions src/VCRC/Components/Ejector.cs
Original file line number Diff line number Diff line change
@@ -1,13 +1,9 @@
namespace VCRC;

/// <summary>
/// Ejector.
/// </summary>
/// <inheritdoc cref="IEjector"/>
public record Ejector : IEjector
{
/// <summary>
/// Ejector.
/// </summary>
/// <inheritdoc cref="Ejector"/>
/// <param name="efficiency">
/// Isentropic efficiency of the nozzle, suction section and diffuser.
/// </param>
Expand All @@ -23,9 +19,7 @@ public record Ejector : IEjector
public Ejector(Ratio efficiency)
: this(efficiency, efficiency, efficiency) { }

/// <summary>
/// Ejector as a VCRC component.
/// </summary>
/// <inheritdoc cref="Ejector"/>
/// <param name="nozzleEfficiency">
/// Isentropic efficiency of the nozzle.
/// </param>
Expand Down
8 changes: 2 additions & 6 deletions src/VCRC/Components/EjectorFlows.cs
Original file line number Diff line number Diff line change
@@ -1,13 +1,9 @@
namespace VCRC;

/// <summary>
/// Ejector flows.
/// </summary>
/// <inheritdoc cref="IEjectorFlows"/>
public class EjectorFlows : IEjectorFlows
{
/// <summary>
/// Ejector flows.
/// </summary>
/// <inheritdoc cref="EjectorFlows"/>
/// <param name="ejector">Ejector.</param>
/// <param name="nozzleInlet">Nozzle inlet.</param>
/// <param name="suctionInlet">Suction section inlet.</param>
Expand Down
8 changes: 2 additions & 6 deletions src/VCRC/Components/Evaporator.cs
Original file line number Diff line number Diff line change
@@ -1,13 +1,9 @@
namespace VCRC;

/// <summary>
/// Evaporator.
/// </summary>
/// <inheritdoc cref="IEvaporator"/>
public record Evaporator : IEvaporator
{
/// <summary>
/// Evaporator.
/// </summary>
/// <inheritdoc cref="Evaporator"/>
/// <param name="refrigerantName">Selected refrigerant name.</param>
/// <param name="temperature">Evaporating temperature (dew point).</param>
/// <param name="superheat">Superheat.</param>
Expand Down
4 changes: 1 addition & 3 deletions src/VCRC/Components/GasCooler.cs
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@ namespace VCRC;
/// </summary>
public record GasCooler : IHeatReleaser
{
/// <summary>
/// Gas cooler.
/// </summary>
/// <inheritdoc cref="GasCooler"/>
/// <remarks>
/// For R744, the absolute pressure in the gas cooler is optional.
/// If it is not specified, then the optimal pressure
Expand Down
2 changes: 1 addition & 1 deletion src/VCRC/Components/IHeatReleaser.cs
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
/// <summary>
/// Heat releaser (condenser or gas cooler).
/// </summary>
public interface IHeatReleaser : IMainHeatExchanger { }
public interface IHeatReleaser : IMainHeatExchanger;
4 changes: 1 addition & 3 deletions src/VCRC/Components/Recuperator.cs
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,7 @@
/// </summary>
public record Recuperator : IAuxiliaryHeatExchanger
{
/// <summary>
/// Recuperator.
/// </summary>
/// <inheritdoc cref="Recuperator"/>
/// <param name="temperatureDifference">
/// Temperature difference at the "hot" side.
/// </param>
Expand Down
3 changes: 3 additions & 0 deletions src/VCRC/EntropyAnalysis/EntropyAnalysisExtensions.cs
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
namespace VCRC;

/// <summary>
/// Entropy analysis extension methods.
/// </summary>
public static class EntropyAnalysisExtensions
{
/// <summary>
Expand Down
4 changes: 1 addition & 3 deletions src/VCRC/EntropyAnalysis/EntropyAnalysisResult.cs
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
namespace VCRC;

/// <summary>
/// Result of the VCRC entropy analysis.
/// </summary>
/// <inheritdoc cref="IEntropyAnalysisResult"/>
/// <param name="ThermodynamicPerfection">
/// Degree of thermodynamic perfection of the cycle (by default, %).
/// </param>
Expand Down
Loading