Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add .ssf for 2020_Bergstrom_HGDP #119

Merged
merged 6 commits into from
Jan 26, 2024
Merged

add .ssf for 2020_Bergstrom_HGDP #119

merged 6 commits into from
Jan 26, 2024

Conversation

nevrome
Copy link
Member

@nevrome nevrome commented May 5, 2023

The poseidon_IDs column is completely empty. Package and .ssf file are not linked.

@93Boy
Copy link
Contributor

93Boy commented Nov 10, 2023

Could not match any field of .ssf into Poseidon_IDs

@stschiff
Copy link
Member

stschiff commented Nov 10, 2023

That is surprising. Anders Bergstrom is one of the few people who know how to properly send data to the ENA. OK, we should take a look into the supplement.

@nevrome
Copy link
Member Author

nevrome commented Dec 18, 2023

@AyGhal and I had a look at this issue and saw that the fifth column of the .ssf file here as an odd column name: hgdp00460.sdg. This corresponds to an actual value in said column. Probably a copy-and-paste error.

This column also seems to feature exactly the information necessary to match .janno and .ssf, because the values there fit to the Poseidon_IDs. Maybe you can check what should be the real name of column five, @93Boy, and then add the necessary poseidon_IDs column? Maybe column number five IS actually the poseidon_IDs column?

@93Boy
Copy link
Contributor

93Boy commented Jan 4, 2024

Fixed in commit #d997710

@stschiff
Copy link
Member

stschiff commented Jan 9, 2024

QUOTATIONS!

@93Boy
Copy link
Contributor

93Boy commented Jan 10, 2024

I have removed the unnecessary quotations

@stschiff
Copy link
Member

OK, check the validation. Checksums need to be updated. Also use trident rectify to also update the Changeling and version.

@stschiff
Copy link
Member

OK, validation passes. If this is ready for review, please check "Ready for review" above to turn it from Draft into Proper PR, @93Boy, Thanks

@nevrome
Copy link
Member Author

nevrome commented Jan 22, 2024

The POSEIDON.yml file now features two sequencingSourceFile entries. Remember to look at the diff @93Boy: https://github.com/poseidon-framework/community-archive/pull/119/files

@stschiff stschiff marked this pull request as ready for review January 26, 2024 09:13
@stschiff
Copy link
Member

Looks good. I think we can merge this, @AyGhal

@AyGhal AyGhal merged commit 57980c4 into master Jan 26, 2024
1 check passed
@AyGhal
Copy link
Contributor

AyGhal commented Jan 26, 2024

I had a quick check, looks good to me. Thanks!

@AyGhal AyGhal deleted the ssfFor2020_Bergstrom_HGDP branch January 26, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants