-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add .ssf for 2020_Bergstrom_HGDP #119
Conversation
Could not match any field of .ssf into Poseidon_IDs |
That is surprising. Anders Bergstrom is one of the few people who know how to properly send data to the ENA. OK, we should take a look into the supplement. |
@AyGhal and I had a look at this issue and saw that the fifth column of the .ssf file here as an odd column name: This column also seems to feature exactly the information necessary to match .janno and .ssf, because the values there fit to the Poseidon_IDs. Maybe you can check what should be the real name of column five, @93Boy, and then add the necessary |
Fixed in commit #d997710 |
QUOTATIONS! |
I have removed the unnecessary quotations |
OK, check the validation. Checksums need to be updated. Also use |
OK, validation passes. If this is ready for review, please check "Ready for review" above to turn it from Draft into Proper PR, @93Boy, Thanks |
The POSEIDON.yml file now features two |
Looks good. I think we can merge this, @AyGhal |
I had a quick check, looks good to me. Thanks! |
The poseidon_IDs column is completely empty. Package and .ssf file are not linked.