Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added missing Poseidon_IDs for 2019_Harber_Crusaders #152

Closed
wants to merge 3 commits into from
Closed

Conversation

93Boy
Copy link
Contributor

@93Boy 93Boy commented Jan 3, 2024

PR Checklist for modifying one or multiple existing packages

  • The changes maintain the structural integrity of the affected packages.
  • The checksums of the modified files in the respective POSEIDON.yml files were adjusted properly.
  • Every file in the submission is correctly referenced in the relevant POSEIDON.yml files and there are no additional, supplementary files in the submission that are not documented there.

  • The packageVersion numbers of the affected packages were increased in their POSEIDON.yml files.
  • The changes were documented in the respective CHANGELOG files. If no CHANGELOG files existed previously it was added here.
  • The lastModified fields of the affected POSEIDON.yml files were updated.
  • The contributor fields were updated with name, email and orcid of the relevant, new contributors.

  • All affected packages pass a validation with trident validate --fullGeno.

  • Large genotype data files are properly tracked with Git LFS and not directly pushed to the repository. For an instruction on how to set up Git LFS please look here. If you accidentally pushed the files the wrong way you can fix it with git lfs migrate import --no-rewrite path/to/file.bed (see here).

@nevrome
Copy link
Member

nevrome commented Jan 8, 2024

Hey Dhana - neat that you added all these .ssf files.

Could you please fill out the PR checklist above? You can just check the boxes by clicking them. You should also adjust the title of this PR to make it clear that this is not just about 2019_Harber_Crusaders.

When looking at the .ssf files I see that they are comma-separated and with quotes. If I remember correctly we need them tab-separated and without quotes.

@stschiff
Copy link
Member

OK, this has become very much outdated. As discussed on Jan 12, please:

  1. Copy out the SSF file locally on your computer
  2. Switch back to the master branch (locally)
  3. Run git pull to update the master branch
  4. Run git switch -c <new_branch> (naming of the branch should make it clear what package it is about)
  5. Add the SSF file, edit the YAML (perhaps using trident rectify to compute Checksums etc.), validate etc.
  6. Commit and push
  7. Create the PR on github
  8. Fill the checklist. Check automatic validation and "Files Changed" for a quick check.

@93Boy
Copy link
Contributor Author

93Boy commented Jan 18, 2024

updated with #153

@stschiff
Copy link
Member

OK, then I'll close this one. Reopen if that was wrong.

@stschiff stschiff closed this Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants