-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding 2023_Koptekin_SouthwestAsia #181
Conversation
Thanks for submits, @93Boy. Could you please fill the checkboxes, and see that you get the automatic checks to pass? |
Thanks for preparing this package, @93Boy. Maybe you could apply some more minor changes to the .janno file:
The validation fails now, because we have already a sample with the Poseidon_ID
What should the process be here, @stschiff, @AyGhal and @TCLamnidis? I suggest we rename the newly added |
I actually see now that you already added the C14 dates, but then removed them again in 69b2347, @dhananjaya93. The way you added them was incorrect, though. The information from the supplementary material must be split for the .janno columns Please check again here what the correct structure for the |
Maybe we should suffix with (part of) the Site name, to avoid future clashes with other samples with the same ID from the same region? |
In this case the site is "Gordion", so |
OK, so first of all, there are again quotations all over, @93Boy. Is that OK with people? |
GOR001 -> Gordion001 |
|
"Can't read sample in ./2023_Koptekin_SouthwestAsia.janno in line 2: parse error (Failed reading: conversion error: Age 2700 later than 2023, which is impossible. Did you accidentally enter a BP date?)" I keep getting this error for C14 start and end Dates. I have gone through supplementary materials multiple times. They all use BCE format. Can you please check and give me a guideline? |
After discussing with @nevrome , We have assumed date formats are in BCE format and done the changes accordingly. Please go through on these data and give a feedback. Apart from this issue , I have found contamination dates but could not find Contamination_Meas in supplementary data. There fore trident rectify cannot recognize the values. Other than these issues , I think this package is ready to publish |
Looks good to me now - will merge. |
PR Checklist for a new package submission
POSEIDON.yml
conforms to the general title structure suggested here:<Year>_<Last name of first author>_<Region, time period or special feature of the paper>
, e.g.2021_Zegarac_SoutheasternEurope
,2021_SeguinOrlando_BellBeaker
or2021_Kivisild_MedievalEstonia
.POSEIDON.yml
file with not just the file-referencing fields, but also the following meta-information fields present and filled:poseidonVersion
,title
,description
,contributor
,packageVersion
,lastModified
(see here for their definition).janno
file (for a list of available fields look here and here for more detailed documentation about them)..bib
file with the necessary literature references for each sample in the.janno
file.POSEIDON.yml
file and there are no additional, supplementary files in the submission that are not documented there..janno
and.bib
file are all named after the package title and only differ in the file extension.POSEIDON.yml
file is1.0.0
.poseidonVersion
of the package in thePOSEIDON.yml
file is set to the latest version of the Poseidon schema.POSEIDON.yml
file contains the corresponding checksums for the fieldsgenoFile
,snpFile
,indFile
,jannoFile
andbibFile
.CHANGELOG
file or one with a single entry for version1.0.0
.Publication
column in the.janno
file is filled and the respective.bib
file has complete entries for the listed mentioned keys..janno
file does not include any empty columns or columns only filled withn/a
..janno
file adheres to the standard order as defined in the Poseidon schema here.trident validate --fullGeno
.git lfs migrate import --no-rewrite path/to/file.bed
(see here).