Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed wrong .janno column names in multiple packages #192

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

nevrome
Copy link
Member

@nevrome nevrome commented Jul 15, 2024

PR Checklist for modifying one or multiple existing packages

  • The changes maintain the structural integrity of the affected packages.
  • The checksums of the modified files in the respective POSEIDON.yml files were adjusted properly.
  • Every file in the submission is correctly referenced in the relevant POSEIDON.yml files and there are no additional, supplementary files in the submission that are not documented there.

  • The packageVersion numbers of the affected packages were increased in their POSEIDON.yml files.
  • The changes in the packageVersion followed the Poseidon Package versioning policy.
  • The changes were documented in the respective CHANGELOG files. If no CHANGELOG files existed previously it was added here.
  • The lastModified fields of the affected POSEIDON.yml files were updated.
  • The contributor fields were updated with name, email and orcid of the relevant, new contributors.
  • The .janno and the .ssf files are not fully quoted, so they only use single- or double quotes ("...", '...') to enclose text fields where it is strictly necessary (i.e. their entry includes a TAB).

  • All affected packages pass a validation with trident validate --fullGeno.

  • Large genotype data files are properly tracked with Git LFS and not directly pushed to the repository. For an instruction on how to set up Git LFS please look here. If you accidentally pushed the files the wrong way you can fix it with git lfs migrate import --no-rewrite path/to/file.bed (see here).

@nevrome nevrome requested review from stschiff and 93Boy July 15, 2024 09:28
@nevrome
Copy link
Member Author

nevrome commented Jul 15, 2024

I found the column name issues when compiling a merged super-dataset.

This is a good motivation for even more strict validation, specifically for the archives. It's certainly not sufficient to report unknown column names on the rather hidden debug log level.

Copy link
Member

@stschiff stschiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, great catches! How on earth did you find the issue with the Note vs. Date_Note in Gretzinger?

Copy link
Contributor

@93Boy 93Boy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dosent trident validate check for the table structure? If not May I make some test to check table structure when someone change a package in PCA?

@nevrome
Copy link
Member Author

nevrome commented Jul 29, 2024

@stschiff: I discovered these issues when creating a super-merged dataset with all packages. There a number of columns emerged that were either not meant to be there or visibly deviated for some packages. I just fixed what caught my eye.

@93Boy: Yes trident does check the table structure thoroughly. But few columns are mandatory and arbitrary additional columns are allowed for the .janno file. This has the effect that such issues can go unnoticed. I think we should introduce a specific --strict mode for trident to check the archives even more rigorously. This should certainly be part of trident. An extra script for this is not desirable, imho.

I'll merge this now to see if the new mastodon tooting action works as expected 👍

@nevrome nevrome merged commit dade852 into master Jul 29, 2024
1 check passed
@nevrome nevrome deleted the wrongColumnNames branch July 29, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants