Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create 2022_Liu_Science_Ancient.janno #199

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

bamorim-bio
Copy link

@bamorim-bio bamorim-bio commented Aug 15, 2024

.janno file for future use.

Liu et al. Science Ancient DNA reveals five streams of migration into Micronesia and matrilocality in early Pacific seafarers 2022 https://www.science.org/doi/10.1126/science.abm6536

@nevrome nevrome added the only .janno This PR does not feature a full package, but only a .janno file label Aug 18, 2024
@stschiff
Copy link
Member

Thanks, @bamorim-bio, great. We'll take a look.

@nevrome
Copy link
Member

nevrome commented Aug 19, 2024

Thanks for preparing this .janno file! I see the following issues

  • The package name does not follow our expected standard of Year_AuthorName_RelevantKeyword. I propose 2022_Liu_Micronesia.
  • Please remove all columns that are completely empty/filled only with n/a.
  • In the lists for Relation_Degree there can not be any n/a values. Documenting a relationship of "unknown" degree would be a pit pointless, right?
  • What do the many other values in Relation_Degree mean? They are not specified in Relation_Type either and are thus not informative. Is there no way to specify them further? At least there should be a an entry in Relation_Note to explain them.
  • The column Endogenous contains a lot of mixed entries, where numbers are expected.
  • Date_C14_Labnr should also include the Laboratory identifier PSUAMS-, not just the number of the age.
  • Date_Note should only document additional details of the dating, not the actual dating. Contextual dates like [1000-1668 CE] should be entered in the columns Date_BC_AD_Start, Date_BC_AD_Median and Date_BC_AD_Stop.

Maybe you could quickly have a look 👍. Please run trident validate --janno on the file after you implemented the necessary changes.

@bamorim-bio
Copy link
Author

Thanks Clemens, here are my changes:

  • The package name does not follow our expected standard of Year_AuthorName_RelevantKeyword. I propose 2022_Liu_Micronesia.
  • Please remove all columns that are completely empty/filled only with n/a.
  • In the lists for Relation_Degree there can not be any n/a values. Documenting a relationship of "unknown" degree would be a pit pointless, right?
  • What do the many other values in Relation_Degree mean? They are not specified in Relation_Type either and are thus not informative. Is there no way to specify them further? At least there should be a an entry in Relation_Note to explain them.
  • The column Endogenous contains a lot of mixed entries, where numbers are expected.
  • Date_C14_Labnr should also include the Laboratory identifier PSUAMS-, not just the number of the age.
  • Date_Note should only document additional details of the dating, not the actual dating. Contextual dates like [1000-1668 CE] should be entered in the columns Date_BC_AD_Start, Date_BC_AD_Median and Date_BC_AD_Stop.

@nevrome nevrome self-assigned this Sep 6, 2024
@stschiff
Copy link
Member

stschiff commented Dec 3, 2024

I will review this Janno once more, and we would like to add the genotype data from AADR here (it's David's labe that made the data, so that should be fine).

@stschiff stschiff self-assigned this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
only .janno This PR does not feature a full package, but only a .janno file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants