-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed country naming proposed in #220 #229
Conversation
…lumn, made file naming consistent
…sNatureCommunications
…oNatureCommunications
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, great. Thanks! Just out of curiosity, I think there should be a PR template form with various checkboxes that appears when you open a new PR. Have you checked this and removed the form?
In any case I think the changes look all good to me.
@stschiff Hi, I removed the template as I was not sure if we keep it when submitting a PR? I just re-read it, and realized I did not check all the boxes. Do I bump up the version number for changes like this? Edit: I put the template back in the description and checked the boxes which my PR fullfills. |
Thanks for bringing the PR checklist back. It should be filled for every PR that changes Poseidon packages in the archive. The package versions must indeed be incremented following these rules: https://github.com/poseidon-framework/poseidon-schema?tab=readme-ov-file#package-versioning Remember that you can do all (!) of these changes for all packages at once (!) with a single call to |
I have now moved this to a new PR directly in this repository. |
Changed RussianFederation to Russian Federation, added Country_ISO column, changed .janno file name to be consistent.
Changes were done in connection to this issue
PR Checklist for modifying one or multiple existing packages
POSEIDON.yml
files were adjusted properly.POSEIDON.yml
files and there are no additional, supplementary files in the submission that are not documented there.packageVersion
numbers of the affected packages were increased in theirPOSEIDON.yml
files.packageVersion
followed the Poseidon Package versioning policy.CHANGELOG
files. If noCHANGELOG
files existed previously it was added here.lastModified
fields of the affectedPOSEIDON.yml
files were updated.contributor
fields were updated withname
,email
andorcid
of the relevant, new contributors..janno
and the.ssf
files are not fully quoted, so they only use single- or double quotes ("..."
,'...'
) to enclose text fields where it is strictly necessary (i.e. their entry includes a TAB).trident validate --fullGeno
.git lfs migrate import --no-rewrite path/to/file.bed
(see here).