Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 2020_Margaryan_Viking: update dates in SSF #25

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

TCLamnidis
Copy link
Member

@TCLamnidis TCLamnidis commented Apr 3, 2024

Changed the date formatting in the SSF to YYYY-MM-DD.

Also: The old ssf validator did not validate the formatting of these columns, but the new one does. So this problem should not happen again.

Closes #24

PR Checklist

  • Add the appropriate label to your PR (new package or package update).
  • The PR title is in the format Add/update package: {package_name}.
  • The PR description includes a link to the issue requesting the package its
    update. (Add to Closes #XXX above.)

If adding or updating a package:

  • This PR contains a sequencingSourceFile (.ssf) for the requested
    package.
  • The name of the .ssf file(s) matches the package name (i.e.
    packages/2023_my_package/2023_my_package.ssf).
  • Comment @delphis-bot create recipe to this pull request to awaken
    Poseidon's trusty helper. (This should be repeated whenever changes are
    made to the SSF file contents).

Delphis-bot will then add a number of files to the PR. Check that they are all
there:

  • The file packages/{package_name}/{package_name}.tsv was added to the PR.
  • The file packages/{package_name}/{package_name}.tsv_patch.sh was added
    to the PR from template.
  • The file packages/{package_name}/script_versions.txt was added to the
    PR.
  • The file packages/{package_name}/{package_name}.config was added to the
    PR from template.

Human validation

Package SSF file (*.ssf)

  • I confirm that the poseidon_IDs, udg, and library_built are filled
    and correct.
  • I made sure to leave notes where necessary to explain any special
    cases/judgement calls made for data entries.

Package TSV file (*.tsv)

  • I confirm that the UDG, Strandedness columns are correct for each
    library.
  • I confirm that the R1_target_file and R2_target_file columns point to
    the correct FastQ files for the library (i.e. consistent with SSF file).

Package config file (*.config)

The template config file includes a few TODO statements, and information about
them. Please ensure that you:

  • I have selected the appropriate config for the CaptureType of the package.
  • If any nf-core/eager parameters need to be altered from their defaults, I
    have added them within the params section at the end of the package
    config file.

@TCLamnidis TCLamnidis self-assigned this Apr 3, 2024
@TCLamnidis
Copy link
Member Author

@delphis-bot create recipe

@TCLamnidis
Copy link
Member Author

The new recipe makes no changes to the eager TSV or script_versions files, as no information has changed.

@TCLamnidis TCLamnidis merged commit 22b815c into main Apr 3, 2024
1 check passed
@TCLamnidis TCLamnidis deleted the update_2020_Margaryan_viking branch April 3, 2024 13:18
@TCLamnidis
Copy link
Member Author

reprocessing triggered for consistency in config profiles etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update packge: 2020_Margaryan_Viking
1 participant