Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #31

Merged
merged 59 commits into from
Apr 3, 2024
Merged

Dev #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
7d02360
Merge branch 'main' into dev
TCLamnidis Nov 2, 2023
9ae4a59
Add preliminary release checklist
TCLamnidis Jan 24, 2024
6bed19b
Merge branch 'dev' of github.com:poseidon-framework/poseidon-eager in…
TCLamnidis Jan 24, 2024
83dd760
Merge branch 'dev' of github.com:poseidon-framework/poseidon-eager in…
TCLamnidis Jan 24, 2024
93288c3
Delete templates that have been moved to minotaur-recipes
TCLamnidis Jan 24, 2024
2e3f25f
Update script with new distributed paths
TCLamnidis Jan 24, 2024
c4a5003
Update local paths
TCLamnidis Jan 24, 2024
1aac0e1
Pull multiqc from tagged remote release of poseidon-eager
TCLamnidis Jan 24, 2024
a80b018
add list of files with versions
TCLamnidis Jan 24, 2024
caffb8a
version info now saved in package readme
TCLamnidis Feb 22, 2024
97adfb2
Merge branch 'dev' of github.com:poseidon-framework/poseidon-eager in…
TCLamnidis Feb 22, 2024
d3e4f64
add debug info in version file function
TCLamnidis Feb 22, 2024
3cc2874
Add more log info
TCLamnidis Feb 22, 2024
548a54e
add line at EOF
TCLamnidis Feb 22, 2024
c2727ee
Clearer log info when moving package to package oven
TCLamnidis Feb 22, 2024
bde10f4
fix package dough publishing
TCLamnidis Feb 22, 2024
bcc6a2f
rename readmeFile. Add readme header
TCLamnidis Feb 23, 2024
b72ddfb
change readme file name
TCLamnidis Feb 23, 2024
7a3476a
add force recreation. fix creation conditional to use bed and not geno
TCLamnidis Feb 23, 2024
e226509
typo bugfix
TCLamnidis Feb 23, 2024
934f928
add log info for -f
TCLamnidis Feb 23, 2024
f798099
remove superfluous function definition
TCLamnidis Mar 14, 2024
4fc4bc5
add SSF to packages
TCLamnidis Mar 14, 2024
a2a5b32
bump version
TCLamnidis Mar 14, 2024
36d4f1a
add endogenous DNA inference
TCLamnidis Mar 14, 2024
47a9138
Merge branch 'dev' of github.com:poseidon-framework/poseidon-eager in…
TCLamnidis Mar 14, 2024
5b67685
update comments
TCLamnidis Mar 15, 2024
69138f9
bump eager version to 2.5.1
TCLamnidis Mar 26, 2024
379d829
Merge branch 'dev' of github.com:poseidon-framework/poseidon-eager in…
TCLamnidis Mar 26, 2024
8816331
release PR template
TCLamnidis Mar 26, 2024
288548a
Merge branch 'main' into dev
TCLamnidis Mar 26, 2024
a83a7a3
remove GA that have now moved repos
TCLamnidis Mar 26, 2024
a210e7d
Merge branch 'dev' of github.com:poseidon-framework/poseidon-eager in…
TCLamnidis Mar 26, 2024
4e4f27a
undo eager version change
TCLamnidis Mar 26, 2024
3d24b30
update PR template
TCLamnidis Mar 26, 2024
e39f7b8
Delete docs/dev/new_release_checklist.md
TCLamnidis Mar 26, 2024
5fcb9cb
deal with PE fastq files.
TCLamnidis Mar 26, 2024
3357e12
version bump
TCLamnidis Mar 26, 2024
50ea43c
Merge branch 'dev' of github.com:poseidon-framework/poseidon-eager in…
TCLamnidis Mar 26, 2024
38a0ef1
add _MNT suffix to ssf when adding to package
TCLamnidis Mar 26, 2024
cc5ebbb
parse endogenous with _MNT suffix
TCLamnidis Mar 26, 2024
55af0a5
remove completed TODO
TCLamnidis Mar 26, 2024
f3861fc
update PR template
TCLamnidis Mar 26, 2024
6c41c12
add pipeline URL, UDG, Lib_built, ploidy
TCLamnidis Mar 26, 2024
a351b58
initial CaptureType inference
TCLamnidis Mar 26, 2024
6f62946
add genetic_accession_ID inference
TCLamnidis Mar 27, 2024
6d1a376
update version
TCLamnidis Mar 27, 2024
9d59454
overwrite udg and accession columns with inferred results. Linting
TCLamnidis Mar 27, 2024
369b02d
add populate_janno.py version to readme.md
TCLamnidis Mar 28, 2024
49d3de8
bugfix Library_Built and Capture_Type
TCLamnidis Mar 28, 2024
c1be326
more bugfix
TCLamnidis Mar 28, 2024
96fda7b
bugfix readme date
TCLamnidis Mar 28, 2024
3f38ed0
ad package name to populate_janno.py announcement.
TCLamnidis Apr 3, 2024
6a4fbc2
convert UDG_Treatment to poseidon format
TCLamnidis Apr 3, 2024
d81045b
bugfix
TCLamnidis Apr 3, 2024
6a31b4d
handle ssDNA datasets
TCLamnidis Apr 3, 2024
2b98ea5
Remove scripts that have moved to recipes repo
TCLamnidis Apr 3, 2024
e752b39
bump versions
TCLamnidis Apr 3, 2024
20f9c1a
Update PULL_REQUEST_TEMPLATE.md
TCLamnidis Apr 3, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 0 additions & 45 deletions .github/ISSUE_TEMPLATE/request_a_package.md

This file was deleted.

52 changes: 0 additions & 52 deletions .github/ISSUE_TEMPLATE/update_a_package.md

This file was deleted.

68 changes: 25 additions & 43 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,43 +1,25 @@
<!--
# poseidon-framework/poseidon-eager package request

Hello there!

Thanks for suggesting a new publication to add to the Poseidon Package Directory!
Please ensure you are completing all the TODOs outlined in these comments for each section.
-->

Closes #XXX <!-- TODO: Please link the issue requesting the package here. -->

## PR Checklist
- [ ] Add the appropriate label to your PR (`new package` or `package_update`).
- [ ] The PR title is in the format `Add/update package: {package_name}`.
- [ ] The PR description includes a link to the issue requesting the package its update. (Add to `Closes #XXX` above.)

If adding a package:
- [ ] This PR contains a sequencingSourceFile (`.ssf`) for the requested package.
- [ ] The name of the `.ssf` file(s) matches the package name (i.e. `packages/2023_my_package/2023_my_package.ssf`).
- [ ] Comment `@delphis-bot create backbone` to this pull request to awaken Poseidon's trusty helper. (This should be repeated whenever changes are made to the SSF file contents).

Delphis-bot will then add a number of files to the PR. Check that they are all there:
- [ ] The file `packages/{package_name}/{package_name}.tsv` was added to the PR.
- [ ] The file `packages/{package_name}/{package_name}.tsv_patch.sh` was added to the PR from template.
- [ ] The file `packages/{package_name}/script_versions.txt` was added to the PR.
- [ ] The file `packages/{package_name}/{package_name}.config` was added to the PR from template.
<!-- TODO: Follow the steps outlined above and tick them off as you go. -->

## Human validation
<!-- TODO: Please do the minimal validation of the files outlined below -->

### Package SSF file (`*.ssf`)
- [ ] I confirm that the `poseidon_IDs`, `udg`, and `library_built` are filled and correct.
- [ ] I made sure to leave `notes` where necessary to explain any special cases/judgement calls made for data entries.

### Package TSV file (`*.tsv`)
- [ ] I confirm that the `UDG`, `Strandedness` columns are correct for each library.
- [ ] I confirm that the `R1_target_file` and `R2_target_file` columns point to the correct FastQ files for the library (i.e. consistent with SSF file).

### Package config file (`*.config`)
The template config file includes a few `TODO` statements, and information about them. Please ensure that you:
- [ ] I have selected the appropriate config for the CaptureType of the package.
- [ ] If any nf-core/eager parameters need to be altered from their defaults, I have added them within the `params` section at the end of the package config file.
<!-- Still preliminary. -->

When a new release is made for minotaur, the following steps should be taken:

- Update the CHANGELOG.md to include a description of all changes.
- Add Release date and bump version number to CHANGELOG.md
- If the eager version was changed:
- [ ] Update the eager version in the [minotaur-recipes repo config temp](https://github.com/poseidon-framework/minotaur-recipes/blob/main/assets/template.config)
- [ ] Update [Minotaur's MultiQC configuration file](https://github.com/poseidon-framework/poseidon-eager/blob/main/conf/minotaur_multiqc_config.yaml)
- [ ] Pull the latest MultiQC config from [nf-core/eager](https://github.com/nf-core/eager/blob/master/assets/multiqc_config.yaml)
- [ ] Apply the required Minotaur tweaks to the config file.
- [ ] Update the eager version in `scripts/populate_janno.py`
- Update the version number in the following files:
- [ ] scripts/download_and_localise_package_files.sh
- [ ] scripts/create_eager_input.sh
- [ ] scripts/minotaur_packager.sh
- [ ] scripts/validate_downloaded_data.sh
- [ ] scripts/run_eager.sh
- [ ] scripts/populate_janno.py
- [ ] scripts/download_ena_data.py
- Create new release, release tag, and name.

After the release:

- Update the poseidon-eager release tag used in the [minotaur-recipes repo](https://github.com/poseidon-framework/minotaur-recipes/blob/main/assets/template.config).
47 changes: 0 additions & 47 deletions .github/workflows/PR_checks.yml

This file was deleted.

111 changes: 0 additions & 111 deletions .github/workflows/create_package_skeleton.yml

This file was deleted.

1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,4 @@ testing_assets/
packages/
poseidon_packages/
.tmp/
packages/
39 changes: 0 additions & 39 deletions assets/template.config

This file was deleted.

Loading