feat: make categories a thing #159
Conversation
| client <- connect() | ||
| create_tag(client, "TAG_CATEGORY_NAME") |
There was a problem hiding this comment.
nit: since we're now creating tag categories, should this be create_tag_category?
There was a problem hiding this comment.
I don't see a function for that in connectapi: https://github.com/search?q=repo%3Arstudio%2Fconnectapi%20create_tag_category&type=code
There was a problem hiding this comment.
Looks good!
I feel like our documentation should explain tags better somewhere lol, I definitely misunderstood it when I edited this one. (i.e. Tags can be nested arbitrarily deep, it's just that the top level that can't be assigned to content which makes them categories.)
| Posit Connect Tag Tree (filtered) | ||
| └── Departments | ||
| ``` | ||
|
|
||
| ::: | ||
|
|
||
| ## Discussion | ||
| Next, create a tag and assign it to the tag category. |
There was a problem hiding this comment.
Perhaps also a note that the method in this section can also be used to nest tags inside other tags, in addition to giving them a parent category.
Agreed. I also think the common confusion is a sign that something else is wrong with the design. I've always wanted to call them folders/directories since that is what they act like. |
|
I have a few editing comments I would have liked to make here - when tagging reviewers, can we leave a little more time for everyone to get a review in before merging, or if urgent just shoot me a message on slack as things come through? I don't have popup email notifications/just check email periodically through the day so that I don't get disrupted for non-urgent things. |
Yes, sorry about that @annikakrilov - I assumed you could still make review comments after a pr is closed, but that isn't the case. For these edits, are you able to make the edits as a separate pull request? |
No description provided.