Update Copilot for 1.104

.esbuild.ts

@@ -48,7 +48,7 @@ const baseNodeBuildOptions = {
 	mainFields: ["module", "main"], // needed for jsonc-parser,
 	define: {
 		'process.env.APPLICATIONINSIGHTS_CONFIGURATION_CONTENT': '"{}"'
-	}
+	},
 } satisfies esbuild.BuildOptions;
 
 const nodeExtHostTestGlobs = [
@@ -68,7 +68,7 @@ const testBundlePlugin: esbuild.Plugin = {
 			return { path: path.resolve(args.path) };
 		});
 		build.onLoad({ filter: /[\/\\]test-extension\.ts$/ }, async args => {
-			let files = await glob(nodeExtHostTestGlobs, { cwd: REPO_ROOT, posix: true });
+			let files = await glob(nodeExtHostTestGlobs, { cwd: REPO_ROOT, posix: true, ignore: ['src/extension/completions-core/**/*'] });
 			files = files.map(f => path.posix.relative('src', f));
 			if (files.length === 0) {
 				throw new Error('No extension tests found');
@@ -98,7 +98,7 @@ const sanityTestBundlePlugin: esbuild.Plugin = {
 			return { path: path.resolve(args.path) };
 		});
 		build.onLoad({ filter: /[\/\\]sanity-test-extension\.ts$/ }, async args => {
-			let files = await glob(nodeExtHostSanityTestGlobs, { cwd: REPO_ROOT, posix: true });
+			let files = await glob(nodeExtHostSanityTestGlobs, { cwd: REPO_ROOT, posix: true, ignore: ['src/extension/completions-core/**/*'] });
 			files = files.map(f => path.posix.relative('src', f));
 			if (files.length === 0) {
 				throw new Error('No extension tests found');
@@ -114,6 +114,23 @@ const sanityTestBundlePlugin: esbuild.Plugin = {
 	}
 };
 
+const importMetaPlugin: esbuild.Plugin = {
+	name: 'claudeCodeImportMetaPlugin',
+	setup(build) {
+		// Handle import.meta.url in @anthropic-ai/claude-code package
+		build.onLoad({ filter: /node_modules[\/\\]@anthropic-ai[\/\\]claude-code[\/\\].*\.mjs$/ }, async (args) => {
+			const contents = await fs.promises.readFile(args.path, 'utf8');
+			return {
+				contents: contents.replace(
+					/import\.meta\.url/g,
+					'require("url").pathToFileURL(__filename).href'
+				),
+				loader: 'js'
+			};
+		});
+	}
+};
+
 const shimVsCodeTypesPlugin: esbuild.Plugin = {
 	name: 'shimVsCodeTypesPlugin',
 	setup(build) {
@@ -160,7 +177,7 @@ const nodeExtHostBuildOptions = {
 		{ in: './src/sanity-test-extension.ts', out: 'sanity-test-extension' },
 	],
 	loader: { '.ps1': 'text' },
-	plugins: [testBundlePlugin, sanityTestBundlePlugin],
+	plugins: [testBundlePlugin, sanityTestBundlePlugin, importMetaPlugin],
 	external: [
 		...baseNodeBuildOptions.external,
 		'vscode'
@@ -221,7 +238,7 @@ const nodeSimulationWorkbenchUIBuildOptions = {
 		'child_process',
 		'http',
 		'assert',
-	]
+	],
 } satisfies esbuild.BuildOptions;
 
 async function typeScriptServerPluginPackageJsonInstall(): Promise<void> {
@@ -326,6 +343,7 @@ async function main() {
 				`**/*.w.json`,
 				'**/*.sqlite',
 				'**/*.sqlite-journal',
+				'test/aml/out/**'
 			]
 		});
 		rebuild();

.eslint-ignore

@@ -10,6 +10,7 @@ test/simulation/fixtures/**
 test/scenarios/**
 .simulation/**
 .eslintplugin/**
+chat-lib/**
 
 # ignore vs
 src/util/vs/**
@@ -26,3 +27,6 @@ src/extension/typescriptContext/serverPlugin/dist/**
 
 # Ignore Built test-extension
 .vscode/extensions/test-extension/dist/**
+
+# Ignore completions-core
+src/extension/completions-core/**

.github/copilot-instructions.md

@@ -23,6 +23,19 @@ This is the **GitHub Copilot Chat** extension for Visual Studio Code - a VS Code
 - **Vitest**: Unit testing framework
 - **Python**: For notebooks integration and ML evaluation scripts
 
+## Validating changes
+
+You MUST check compilation output before running ANY script or declaring work complete!
+
+1. **ALWAYS** check the `start-watch-tasks` watch task output for compilation errors
+2. **NEVER** use the `compile` task as a way to check if everything is working properly
+3. **FIX** all compilation errors before moving forward
+
+### TypeScript compilation steps
+- Monitor the `start-watch-tasks` task outputs for real-time compilation errors as you make changes
+- This task runs `npm: watch:tsc-extension`,`npm: watch:tsc-extension-web`, `npm: watch:tsc-simulation-workbench`, and `npm: watch:esbuild` to incrementally compile the project
+- Start the task if it's not already running in the background
+
 ## Project Architecture
 
 ### Top-Level Directory Structure
@@ -319,3 +332,7 @@ The extension uses numerous proposed VS Code APIs for advanced functionality:
 - **Configuration**: Modify `package.json` contributions for VS Code integration
 
 This extension is a complex, multi-layered system that provides comprehensive AI assistance within VS Code. Understanding the service architecture, contribution system, and separation between platform and extension layers is crucial for making effective changes.
+
+## Best Practices
+- Use services and dependency injection whenever possible instead of using node or vscode APIs directly. For example, use `IFileService` instead of node's `fs`.
+- Always use the URI type instead of using string file paths. There are many helpers available for working with URIs.

.github/instructions/prompt-tsx.instructions.md

@@ -0,0 +1,167 @@
+---
+applyTo: '**/*.tsx'
+description: Prompt-TSX coding guidelines
+---
+
+Guidelines for TSX files using [prompt-tsx](https://github.com/microsoft/vscode-prompt-tsx) focusing on specific patterns and token budget management for AI prompt engineering.
+
+## Component Structure
+
+### Base Pattern
+- Extend `PromptElement<Props>` or `PromptElement<Props, State>` for all prompt components
+- Props interfaces must extend `BasePromptElementProps`
+
+```tsx
+interface MyPromptProps extends BasePromptElementProps {
+	readonly userQuery: string;
+}
+
+class MyPrompt extends PromptElement<MyPromptProps> {
+	render() {
+		return (
+			<>
+				<SystemMessage priority={1000}>...</SystemMessage>
+				<UserMessage priority={900}>{this.props.userQuery}</UserMessage>
+			</>
+		);
+	}
+}
+```
+
+### Async Components
+- The `render` method can be async for components that need to perform async operations
+- All async work should be done directly in the `render` method
+
+```tsx
+class FileContextPrompt extends PromptElement<FileContextProps> {
+	async render() {
+		const fileContent = await readFileAsync(this.props.filePath);
+		return (
+			<>
+				<SystemMessage priority={1000}>File content:</SystemMessage>
+				<UserMessage priority={900}>{fileContent}</UserMessage>
+			</>
+		);
+	}
+}
+```
+
+## Prompt-Specific JSX
+
+### Line Breaks
+- **CRITICAL**: Use `<br />` for line breaks - newlines are NOT preserved in JSX
+- Never rely on whitespace or string literal newlines
+
+```tsx
+// ✅ Correct
+<SystemMessage>
+	You are an AI assistant.<br />
+	Follow these guidelines.<br />
+</SystemMessage>
+
+// ❌ Wrong - newlines will be collapsed
+<SystemMessage>
+	You are an AI assistant.
+	Follow these guidelines.
+</SystemMessage>
+```
+
+## Priority System
+
+### Priority Values
+- Higher numbers = higher priority (like z-index)
+- Use consistent ranges:
+  - System messages: 1000
+  - User queries: 900
+  - Recent history: 700-800
+  - Context/attachments: 600-700
+  - Background info: 0-500
+
+```tsx
+<SystemMessage priority={1000}>...</SystemMessage>
+<UserMessage priority={900}>{query}</UserMessage>
+<HistoryMessages priority={700} />
+<ContextualData priority={500} />
+```
+
+### Flex Properties for Token Budget
+- `flexGrow={1}` - expand to fill remaining token space
+- `flexReserve` - reserve tokens before rendering
+- `passPriority` - pass-through containers that don't affect child priorities
+
+```tsx
+<FileContext priority={70} flexGrow={1} files={this.props.files} />
+<History passPriority older={0} newer={80} flexGrow={2} flexReserve="/5" />
+```
+
+## Content Handling
+
+### TextChunk for Truncation
+- Use `TextChunk` for content that may exceed token budget
+- Set `breakOn` patterns for intelligent truncation
+
+```tsx
+<TextChunk breakOnWhitespace priority={100}>
+	{longUserQuery}
+</TextChunk>
+
+<TextChunk breakOn=" " priority={80}>
+	{documentContent}
+</TextChunk>
+```
+
+### Tag Component for Structured Content
+- Use `Tag` for XML-like structured content with attributes
+- Validates tag names and properly formats attributes
+
+```tsx
+<Tag name="attachments" attrs={{ id: variableName, type: "file" }}>
+	{content}
+</Tag>
+```
+
+## References and Metadata
+
+### Prompt References
+- Use `<references>` for tracking variable usage
+- Use `<meta>` for metadata that survives pruning
+
+```tsx
+<references value={[new PromptReference({ variableName })]} />
+<meta value={new ToolResultMetadata(id, result)} />
+```
+
+### Keep-With Pattern
+- Use `useKeepWith()` for content that should be pruned together
+
+```tsx
+const KeepWith = useKeepWith();
+return (
+	<>
+		<KeepWith priority={2}>
+			<ToolCallRequest>...</ToolCallRequest>
+		</KeepWith>
+		<KeepWith priority={1}>
+			<ToolCallResponse>...</ToolCallResponse>
+		</KeepWith>
+	</>
+);
+```
+
+## Token Budget Management
+
+### Sizing-Aware Rendering
+- Use `PromptSizing` parameter for budget-aware content generation
+- Implement cooperative token usage
+
+```tsx
+async render(sizing: PromptSizing): Promise<PromptPiece> {
+	const content = await this.generateContent(sizing.tokenBudget);
+	return <>{content}</>;
+}
+```
+
+### Performance
+- Avoid expensive work in `render` methods when possible
+- Cache computations when appropriate
+- Use async `render` for all async operations

.github/instructions/vitest-unit-tests.instructions.md

@@ -0,0 +1,14 @@
+---
+applyTo: '**/*.spec.ts'
+description: Vitest unit testing guidelines
+---
+
+Guidelines for writing unit tests using Vitest. These tests are `*.spec.ts`
+
+## Best Practices
+
+- Use proper mocks when possible rather than ad-hoc objects injected as dependencies. For example, call `createExtensionUnitTestingServices` to get some mock services, and `IInstantiationService` to create instances with those mocks.
+- If there is no preexisting implementation of a service that is appropriate to reuse in the test, then you can create a simple mock or stub implementation.
+- Avoid casting to `any` whenever possible.
+- When asked to write new tests, add tests for things that are interesting and nontrivial. Don't add a test that just verifies that a setter/getter work.
+- Prefer the runTests tool to run tests over a terminal command.

.github/workflows/pr.yml

@@ -89,6 +89,11 @@ jobs:
           python-version: '3.12'
           architecture: 'x64'
 
+      - name: Setup .NET
+        uses: actions/setup-dotnet@v4
+        with:
+          dotnet-version: '10.0'
+
       - name: Install setuptools
         run: pip install setuptools
 
@@ -116,9 +121,6 @@ jobs:
           mkdir -p .build/build_cache
           tar -czf .build/build_cache/cache.tgz --files-from .build/build_cache_list.txt
 
-      - name: Install dotnet cli
-        run: npm run setup:dotnet
-
       - name: TypeScript type checking
         run: npm run typecheck
 
@@ -171,6 +173,11 @@ jobs:
           python-version: '3.12'
           architecture: 'x64'
 
+      - name: Setup .NET
+        uses: actions/setup-dotnet@v4
+        with:
+          dotnet-version: '10.0'
+
       - name: Install setuptools
         run: pip install setuptools
 

.gitignore

@@ -45,3 +45,4 @@ coverage/
 test/simulation/cache/_base.sqlite
 
 test/aml/out
+src/extension/completions-core

.mocha-multi-reporters.js

@@ -0,0 +1,33 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the MIT License. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+const path = require('path');
+
+// In CI, the name of the NPM command that was run is used to generate a unique
+// filename for the JUnit report. The name we give it is then used as the test
+// bundle name in DataDog.
+const commandToBundleName = {
+	isolatedProxyTests: 'IsolatedProxy',
+	reverseProxyTests: 'ReverseProxy',
+	test: 'LSPClient',
+	'test:agent': 'Agent',
+	'test:lib': 'Lib',
+	'test:lib-e2e': 'LibEndToEnd',
+};
+
+const config = {
+	reporterEnabled: 'spec',
+};
+
+if (process.env.CI) {
+	const bundleName = commandToBundleName[process.env.npm_lifecycle_event] || 'Unit';
+	config.reporterEnabled += ', mocha-junit-reporter';
+	config.mochaJunitReporterReporterOptions = {
+		testCaseSwitchClassnameAndName: true,
+		testsuitesTitle: `Copilot ${bundleName} Tests`,
+		mochaFile: path.resolve(__dirname, `test-results-${bundleName}.xml`),
+	};
+}
+
+module.exports = config;