still looking

posit-dev · Jan 31, 2025 · 32a02b0 · 32a02b0
1 parent d5565b4
commit 32a02b0
Show file tree

Hide file tree

Showing 2 changed files with 60 additions and 66 deletions.
diff --git a/.github/workflows/positron-python-ci.yml b/.github/workflows/positron-python-ci.yml
@@ -410,68 +410,66 @@ jobs:
         env:
           POSITRON_GITHUB_PAT: ${{ github.token }}
         run: |
-          ls
-          ls tmp/ext/smokeTestExtensionsFolder/
-          ls tmp/ext
+          ls python-env-tools
           cd npx tsc && node ./out/test/smokeTest.js
         if: matrix.test-suite == 'smoke'
 
-  build-vsix:
-    name: Create VSIX
-    runs-on: ${{ matrix.os }}
-    strategy:
-      fail-fast: false
-      matrix:
-        include:
-          # - os: windows-latest
-          #   target: x86_64-pc-windows-msvc
-          #   vsix-target: win32-x64
-          # - os: windows-latest
-          #   target: aarch64-pc-windows-msvc
-          #   vsix-target: win32-arm64
-          - os: ubuntu-latest
-            target: x86_64-unknown-linux-musl
-            vsix-target: linux-x64
-          # - os: ubuntu-latest
-          #   target: x86_64-unknown-linux-musl
-          #   vsix-target: alpine-x64
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-
-      - name: Build VSIX
-        uses: ./.github/actions/python-build-vsix
-        with:
-          node_version: ${{ env.NODE_VERSION}}
-          vsix_name: 'positron-python-dev-${{ matrix.vsix-target }}.vsix'
-          artifact_name: 'positron-python-dev-vsix-${{ matrix.vsix-target }}'
-          cargo_target: ${{ matrix.target }}
-          vsix_target: ${{ matrix.vsix-target }}
-          path: '${{ env.PROJECT_DIR}}/python-env-tools'
-
-  smoke-tests:
-    name: Smoke tests
-    # The value of runs-on is the OS of the current job (specified in the strategy matrix below) instead of being hardcoded.
-    runs-on: ${{ matrix.os }}
-    needs: [build-vsix]
-    strategy:
-      fail-fast: false
-      matrix:
-        # We're not running CI on macOS for now because it's one less matrix entry to lower the number of runners used,
-        # macOS runners are expensive, and we assume that Ubuntu is enough to cover the UNIX case.
-        include:
-          # - os: windows-latest
-          #   vsix-target: win32-x64
-          - os: ubuntu-latest
-            vsix-target: linux-x64
-
-    steps:
-      # Need the source to have the tests available.
-      - name: Checkout
-        uses: actions/checkout@v4
-
-      - name: Smoke tests
-        uses: ./.github/actions/python-smoke-tests
-        with:
-          node_version: ${{ env.NODE_VERSION }}
-          artifact_name: 'positron-python-dev-vsix-${{ matrix.vsix-target }}'
+  # build-vsix:
+  #   name: Create VSIX
+  #   runs-on: ${{ matrix.os }}
+  #   strategy:
+  #     fail-fast: false
+  #     matrix:
+  #       include:
+  #         # - os: windows-latest
+  #         #   target: x86_64-pc-windows-msvc
+  #         #   vsix-target: win32-x64
+  #         # - os: windows-latest
+  #         #   target: aarch64-pc-windows-msvc
+  #         #   vsix-target: win32-arm64
+  #         - os: ubuntu-latest
+  #           target: x86_64-unknown-linux-musl
+  #           vsix-target: linux-x64
+  #         # - os: ubuntu-latest
+  #         #   target: x86_64-unknown-linux-musl
+  #         #   vsix-target: alpine-x64
+  #   steps:
+  #     - name: Checkout
+  #       uses: actions/checkout@v4
+
+  #     - name: Build VSIX
+  #       uses: ./.github/actions/python-build-vsix
+  #       with:
+  #         node_version: ${{ env.NODE_VERSION}}
+  #         vsix_name: 'positron-python-dev-${{ matrix.vsix-target }}.vsix'
+  #         artifact_name: 'positron-python-dev-vsix-${{ matrix.vsix-target }}'
+  #         cargo_target: ${{ matrix.target }}
+  #         vsix_target: ${{ matrix.vsix-target }}
+  #         path: '${{ env.PROJECT_DIR}}/python-env-tools'
+
+  # smoke-tests:
+  #   name: Smoke tests
+  #   # The value of runs-on is the OS of the current job (specified in the strategy matrix below) instead of being hardcoded.
+  #   runs-on: ${{ matrix.os }}
+  #   needs: [build-vsix]
+  #   strategy:
+  #     fail-fast: false
+  #     matrix:
+  #       # We're not running CI on macOS for now because it's one less matrix entry to lower the number of runners used,
+  #       # macOS runners are expensive, and we assume that Ubuntu is enough to cover the UNIX case.
+  #       include:
+  #         # - os: windows-latest
+  #         #   vsix-target: win32-x64
+  #         - os: ubuntu-latest
+  #           vsix-target: linux-x64
+
+  #   steps:
+  #     # Need the source to have the tests available.
+  #     - name: Checkout
+  #       uses: actions/checkout@v4
+
+  #     - name: Smoke tests
+  #       uses: ./.github/actions/python-smoke-tests
+  #       with:
+  #         node_version: ${{ env.NODE_VERSION }}
+  #         artifact_name: 'positron-python-dev-vsix-${{ matrix.vsix-target }}'
diff --git a/extensions/positron-python/src/test/smokeTest.ts b/extensions/positron-python/src/test/smokeTest.ts
@@ -34,10 +34,6 @@ class TestRunner {
         const env: Record<string, {}> = {
             VSC_PYTHON_SMOKE_TEST: '1',
             CODE_EXTENSIONS_PATH: SMOKE_TEST_EXTENSIONS_DIR,
-            // --- Start Positron ---
-            // update root dir to start up PET successfully
-            EXTENSION_ROOT_DIR: EXTENSION_ROOT_DIR_FOR_TESTS,
-            // --- End Positron ---
         };
 
         await this.launchTest(env);