Skip to content

Commit

Permalink
test windows
Browse files Browse the repository at this point in the history
  • Loading branch information
midleman committed Dec 9, 2024
1 parent ecd5aa7 commit 60900f5
Show file tree
Hide file tree
Showing 3 changed files with 28 additions and 31 deletions.
43 changes: 22 additions & 21 deletions .github/workflows/e2e-nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,16 +34,16 @@ on:
- always

jobs:
e2e-electron:
name: test
if: ${{ inputs.run_e2e_linux == true || inputs.run_e2e_linux == null }}
uses: ./.github/workflows/e2e-linux.yml
with:
grep: "@dummy-test"
project: "e2e-electron"
display_name: "e2e-electron"
currents_tags: "@nightly,@electron/linux"
secrets: inherit
# e2e-electron:
# name: test
# if: ${{ inputs.run_e2e_linux == true || inputs.run_e2e_linux == null }}
# uses: ./.github/workflows/e2e-linux.yml
# with:
# grep: "@dummy-test"
# project: "e2e-electron"
# display_name: "e2e-electron"
# currents_tags: "@nightly,@electron/linux"
# secrets: inherit

e2e-windows:
name: test
Expand All @@ -55,19 +55,20 @@ jobs:
currents_tags: "@nightly,@electron/win"
secrets: inherit

e2e-browser:
name: test
if: ${{ inputs.run_e2e_browser == true || inputs.run_e2e_browser == null }}
uses: ./.github/workflows/e2e-linux.yml
with:
grep: "@dummy-test"
project: "e2e-browser"
display_name: "e2e-browser"
currents_tags: "@nightly,@browser/linux"
secrets: inherit
# e2e-browser:
# name: test
# if: ${{ inputs.run_e2e_browser == true || inputs.run_e2e_browser == null }}
# uses: ./.github/workflows/e2e-linux.yml
# with:
# grep: "@dummy-test"
# project: "e2e-browser"
# display_name: "e2e-browser"
# currents_tags: "@nightly,@browser/linux"
# secrets: inherit

slack-notify:
needs: [e2e-electron, e2e-windows, e2e-browser]
# needs: [e2e-electron, e2e-windows, e2e-browser]
needs: [e2e-windows]
runs-on: ubuntu-latest
if: always()
steps:
Expand Down
12 changes: 4 additions & 8 deletions .github/workflows/e2e-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -155,12 +155,8 @@ jobs:
if: ${{ !cancelled() }}
run: npx playwright test --project "e2e-windows" --grep "${{ env.PW_TAGS }}" --workers 2 --repeat-each ${{ inputs.repeat_each }}

- name: Report Test Results
uses: ./.github/actions/e2e-report
if: always()
- name: Upload Playwright Report to S3
if: ${{ success() || failure() }}
uses: ./.github/actions/upload-report-to-s3
with:
aws-s3-bucket: positron-test-reports
aws-role: ${{ secrets.AWS_TEST_REPORTS_ROLE }}
# testrail-api-key: ${{ secrets.TESTRAIL_API_KEY }}
# testrail-title: "E2E Electron Test Run"

role-to-assume: ${{ secrets.AWS_TEST_REPORTS_ROLE }}
4 changes: 2 additions & 2 deletions build/secrets/.secrets.baseline
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@
"filename": ".github/workflows/e2e-nightly.yml",
"hashed_secret": "3e26d6750975d678acb8fa35a0f69237881576b0",
"is_verified": false,
"line_number": 46
"line_number": 56
}
],
".github/workflows/pr-merge-push.yml": [
Expand Down Expand Up @@ -1924,5 +1924,5 @@
}
]
},
"generated_at": "2024-12-09T16:20:13Z"
"generated_at": "2024-12-09T16:32:29Z"
}

0 comments on commit 60900f5

Please sign in to comment.