Skip to content

Commit

Permalink
test fail/flakes
Browse files Browse the repository at this point in the history
  • Loading branch information
midleman committed Jan 25, 2025
1 parent 59a6118 commit 90d9548
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 2 deletions.
1 change: 1 addition & 0 deletions .github/workflows/test-pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ jobs:
secrets: inherit

slack-notify:
if: always()
needs: [e2e-linux-electron] #, e2e-windows-electron, e2e-linux-browser]
runs-on: ubuntu-latest
steps:
Expand Down
8 changes: 7 additions & 1 deletion test/e2e/tests/console/console-ansi.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ test.describe('Console ANSI styling', { tag: [tags.CRITICAL, tags.CONSOLE, tags.
});

test("R - Can produce clickable file links", async function ({ app, r }) {
expect(1).toBe(2);
// Can be any file on the workkspace. We use .gitignore as it's probably
// always there.
const fileName = '.gitignore';
Expand All @@ -35,7 +36,12 @@ test.describe('Console ANSI styling', { tag: [tags.CRITICAL, tags.CONSOLE, tags.
}).toPass({ timeout: 60000 });
});

test("R - Can produce clickable help links", async function ({ app, r }) {
test("R - Can produce clickable help links", async function ({ app, r }, testInfo) {
if (testInfo.retry) {
expect(2).toBe(2); // Intentionally fail
} else {
expect(1).toBe(2); // Pass
}
const inputCode = `cli::cli_inform("{.fun base::mean}")`;

await expect(async () => {
Expand Down
1 change: 0 additions & 1 deletion test/e2e/tests/editor-action-bar/document-files.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ test.describe('Editor Action Bar: Document Files', {
test('R Markdown Document', {
tag: [tags.R_MARKDOWN]
}, async function ({ app, openFile }) {
expect(1).toBe(2);
await openFile('workspaces/basic-rmd-file/basicRmd.rmd');
await verifyPreviewRendersHtml('Getting startedAnchor');
await verifySplitEditor('basicRmd.rmd');
Expand Down

0 comments on commit 90d9548

Please sign in to comment.