Readdress 5737 fixing the actual cause #5891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 ? |
juliasilge
reviewed
Jan 7, 2025
There was a problem hiding this comment.
When I build from this PR, I don't quite see as good behavior as I did with #5834. Specifically, when I click only once on one of these buttons:
it does not do anything. When I click a second time, then it does in fact go ahead with whatever action needs to happen, like split right or start the publishing process.
What do you think? Do you also see the behavior around the first click vs. the second one?
isabelizimm
reviewed
Jan 7, 2025
isabelizimm
approved these changes
Jan 7, 2025
juliasilge
approved these changes
Jan 8, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR readdresses #5737 by fixing the actual cause of the issue. With this PR, mouse down events do not steal focus when they occur inside a Positron action bar. This workaround was borrowed from code in
handleTitleClickOrTouchthat does the same thing for Monaco action bars.@:editor-action-bar
QA Notes
None.