-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python: use Python Environment Tools for interpreter discovery #5897
Merged
Merged
Changes from 37 commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
2d1658c
install PET in CI
isabelizimm 72ce282
install nox into ci
isabelizimm 5d4a4cf
take into account different wd for ts tests
isabelizimm 3e317cb
specify which noxfile
isabelizimm 9c2ddba
use actions for smoke tests to build vsix
isabelizimm c8db8b0
correct path name
isabelizimm 06d13d4
cd into positron-python every time(?)
isabelizimm f1d2c1f
format yml
isabelizimm 8b247ed
place pet in project dir
isabelizimm 8ba5db2
do not clone with special-working-dir
isabelizimm 77efe40
debug where vsix is
isabelizimm 55b7461
rm tmate session
isabelizimm c0ddffb
move to ext dir
isabelizimm b01e189
try quotes perhaps
isabelizimm 383cf53
try to move file again
isabelizimm c5a64c9
using working-directory arg
isabelizimm 018cd9f
no working dir for upload
isabelizimm 2d9ca1b
use cp instead of mv
isabelizimm c57dca8
upload vsix for smoke tests
isabelizimm db5cf4c
update paths for smoke tests
isabelizimm 69dbdb1
include version in interpreter name
isabelizimm aed1167
add pet specific tests
isabelizimm 5dcf7bf
include PROJECT_DIR for cargo tests
isabelizimm ad4dbb1
scripts to download and unzip python-env-tools
isabelizimm 8fc277c
script to build pet
isabelizimm b6f7586
copyright headers
isabelizimm 89b0949
use positron-pet-builds
isabelizimm 57ad325
update e2e test
isabelizimm afa542e
Merge branch 'main' into pet-python
isabelizimm f1ace23
move test to new dir
isabelizimm 74040e9
add post-install script
isabelizimm a683063
Merge branch 'main' into pet-python
isabelizimm 8ce1c69
adjust imports for install
isabelizimm 73c97fc
Merge branch 'main' into pet-python
isabelizimm 82bfd96
remove extra test infra in favor of npm ci
isabelizimm 5d65c03
debug ci
isabelizimm 4ed7fb7
remove ls in gha
isabelizimm 0ad2fb4
give PAT to npm ci
isabelizimm 54f78c0
try other GH_TOKEN
isabelizimm 3970bfb
use PAT, but different env name?
isabelizimm 7e43c23
run config cred?
isabelizimm 655336b
include python-env-tools in build
isabelizimm 881868f
new actions to build for smoke tests
isabelizimm 920399f
mv smoke test
isabelizimm ddc6c2f
set 3.10 to avoid errors on 3.13
isabelizimm 7a6d30a
change extension root dir for smoke tests
isabelizimm d5565b4
where did the PET go????
isabelizimm 32a02b0
still looking
isabelizimm 8beb26e
allow execute
isabelizimm 5aa013b
one more try
isabelizimm 8ea8a99
use new PAT
isabelizimm ab81512
use SMOKE_TEST_EXTENSIONS_DIR
isabelizimm e786a2d
ensureDir the pet exists
isabelizimm ea0e52e
chmod pet
isabelizimm 225e149
error earlier
isabelizimm 9f7dfd1
swap default to js
isabelizimm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
name: "Setup Python Environment Tools" | ||
description: "Install and build microsoft/python-environment-tools" | ||
|
||
env: | ||
PET_BRANCH: "release/latest" | ||
|
||
runs: | ||
using: "composite" | ||
steps: | ||
- name: Checkout Python Environment Tools | ||
uses: actions/checkout@v4 | ||
with: | ||
repository: 'microsoft/python-environment-tools' | ||
path: 'extensions/positron-python/python-env-tools' | ||
branch: ${{ env.PET_BRANCH }} | ||
sparse-checkout: | | ||
crates | ||
Cargo.toml | ||
Cargo.lock | ||
sparse-checkout-cone-mode: false | ||
|
||
- name: Rust Tool Chain setup | ||
uses: dtolnay/rust-toolchain@stable | ||
|
||
- name: Build Native Binaries | ||
run: nox --noxfile extensions/positron-python/noxfile.py --session native_build | ||
shell: bash |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now, the rust locator is considered experimental and is opt-in only for upstream. I've swapped it for testing purposes, but we'll want to decide what we want as the default. I've played around with it locally, and it seems to be finding everything and is MUCH FASTER, eg, 1-3 seconds to find my 80+ envs. We should do a bit more robust testing before deciding though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've had the same experience. We could leave the default as
js
when we merge tomain
so that it's optional for the Feb release, and make it the default onmain
for devs to test during Feb in preparation for the Mar release?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good! Once this is merged and we have a build, I can make a discussion post asking for people to opt-in for more feedback 🕺