Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command for opening an HTML file in a browser #6071

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

jmcphers
Copy link
Collaborator

This change adds an "Open in Browser" command to HTML files to go with "Open in Viewer", based on user feedback that it is not obvious how to open an HTML file in a browser if you're looking at it in Positron.

Addresses #6047.

Release Notes

New Features

Bug Fixes

  • N/A

QA Notes

  • This change exists only in the Positron Proxy extension and thus should not affect any core scenarios.
  • I changed the icon for the "Open in Viewer" command to "preview" since I think it's better suited to the gesture.

@jmcphers jmcphers requested a review from softwarenerd January 21, 2025 23:24
Copy link

github-actions bot commented Jan 21, 2025

E2E Tests 🚀
This PR will run tests tagged with: @:critical

readme  valid tags

@petetronic
Copy link
Collaborator

I tried out the new command and the new Open in Browser button appeared as expected and worked to open .html files in my default browser. However, using Cmd+Shift+P to select the command "Open in Browser", I got an error:
Screenshot 2025-01-24 at 6 59 50 PM

@jmcphers
Copy link
Collaborator Author

Thanks, I had not anticipated the use of this command from the Palette! That should work now, as long as you've got an HTML file open in the editor (otherwise you should get a friendly error).

Copy link
Contributor

@softwarenerd softwarenerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@jmcphers jmcphers merged commit c35daad into main Jan 29, 2025
8 checks passed
@jmcphers jmcphers deleted the feature/open-browser-preview branch January 29, 2025 04:05
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants