rename positron/positron_ipykernel to posit/positron
#6085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 |
isabelizimm
commented
Jan 22, 2025
| @@ -43,6 +46,19 @@ | |||
|
|
|||
| _sentinel = object() | |||
|
|
|||
| # update Jedi cache to not conflict with other Jedi instances | |||
| if platform.system().lower() == "windows": | |||
There was a problem hiding this comment.
Learnt from prior changes in this module, if we do not update the cache we will not get any completions (slack conversation)
Adapted from jedi.settings.cache_directory
wesm
approved these changes
Jan 22, 2025
seeM
approved these changes
Jan 23, 2025
| @@ -43,6 +46,19 @@ | |||
|
|
|||
| _sentinel = object() | |||
|
|
|||
| # update Jedi cache to not conflict with other Jedi instances | |||
| if platform.system().lower() == "windows": | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes
New Features
Bug Fixes
positron-pythonpaths are too long in Windows Error during user setup installation #4387QA Notes
should pass all tests. you should also still be able to run a local build and the LSP works.