Adds indicator in console when extension host is disconnected #6089
+48
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 |
Also fixes ext. host indicator showing during unrelated disconnections
jmcphers
requested changes
Jan 24, 2025
|
|
||
| let extensionHostDisconnected = false; | ||
|
|
||
| const reversedItems = this.props.positronConsoleInstance.runtimeItems.slice().reverse(); |
There was a problem hiding this comment.
There can be a lot of runtime items, so the copy made by slice() could be expensive (which matters since this runs on every render). I would recommend just adding a flag we can check. If we do need a loop we could just index backwards?
| {extensionHostDisconnected ? | ||
| (<div className='console-item-reconnecting'> | ||
| <span className='codicon codicon-loading codicon-modifier-spin'></span> | ||
| <span>Extensions restarting...</span> |
There was a problem hiding this comment.
This string needs to be localized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds indicator and helpful message in console when extension host is disconnected, replacing the prompt. When the extension host comes back, the prompt is restored.
Addresses #5444
Release Notes
New Features
Bug Fixes
QA Notes