Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e-test: add terminal and console contents to e2e logs #6115

Merged
merged 5 commits into from
Jan 24, 2025
Merged

e2e-test: add terminal and console contents to e2e logs #6115

merged 5 commits into from
Jan 24, 2025

Conversation

midleman
Copy link
Contributor

@midleman midleman commented Jan 24, 2025 •
edited
Loading

Summary

  • Added method to log Terminal Contents to e2e-test-runner.log.
  • Configured the auto test fixture to always logs Terminal and Console contents after each test.

QA Notes

  • Reviewed output of e2e-test-runner.log to confirm contents appear as expected.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 24, 2025 •
edited
Loading

E2E Tests 🚀
This PR will run tests tagged with: @:critical

readme  valid tags

@midleman midleman marked this pull request as ready for review January 24, 2025 12:45
testlabauto
testlabauto approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@testlabauto testlabauto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea! LGTM!

@midleman midleman merged commit a70d1f0 into main Jan 24, 2025
14 of 15 checks passed
@midleman midleman deleted the mi/log-terminal-contents branch January 24, 2025 15:18
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@testlabauto testlabauto testlabauto approved these changes

@jmcphers jmcphers Awaiting requested review from jmcphers

@jonvanausdeln jonvanausdeln Awaiting requested review from jonvanausdeln

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@midleman @testlabauto