Display active runtime metadata in console pane #6156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 |
softwarenerd
requested changes
Jan 30, 2025
src/vs/workbench/contrib/positronConsole/browser/components/consoleInstanceInfoButton.css
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/positronConsole/browser/components/consoleInstanceInfoButton.css
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/positronConsole/browser/components/consoleInstanceInfoButton.tsx
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/positronConsole/browser/components/consoleInstanceInfoButton.tsx
Show resolved
Hide resolved
src/vs/workbench/services/runtimeSession/common/positronMultipleConsoleSessionsFeatureFlag.ts
Outdated
Show resolved
Hide resolved
juliasilge
previously approved these changes
Jan 30, 2025
There was a problem hiding this comment.
Working well for me!
Can we open a followup issue to re-examine the treatment of the top action bar of the console at narrower widths? Especially after the coming major UI changes (probably not worth it before). See for example how when I choose the "side-by-side" layout at a moderate app size, I get some not great behavior:
console-bar.mov
No need to check if a session is undefined because we are guaranteed to get a session
dhruvisompura
dismissed stale reviews from softwarenerd and juliasilge
via
243e45c
sharon-wang
previously approved these changes
Jan 31, 2025
src/vs/workbench/contrib/positronConsole/browser/components/consoleInstanceInfoButton.tsx
Show resolved
Hide resolved
| popupPosition='auto' | ||
| width={400} | ||
| > | ||
| <div className='console-instance-info'> |
There was a problem hiding this comment.
A idea for the future -- thoughts on making the text copy-able? In particular, it would be great if the interpreter path was copy-able.
There was a problem hiding this comment.
Agreed! This is something I noticed and made a note about in the epic around cleanup/improvements!
sharon-wang
reviewed
Jan 31, 2025
src/vs/workbench/contrib/positronConsole/browser/components/consoleInstanceInfoButton.tsx
Outdated
Show resolved
Hide resolved
dhruvisompura
dismissed stale reviews from sharon-wang and softwarenerd
via
32e4dcc
!
dhruvisompura
deleted the
feature/display-active-runtime-metadata-in-console-pane
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #5999
Adds a new feature flag called
positron.multipleConsoleSessions. When the feature flag is on users can now view details for an active session by clicking on the new info icon button that lives in the console pane action bar. A modal popup will render, containing the details of the session, such as name, state, id, interpreter path, and environment management tool.The popup provides a link to the session logs in the output pane. When clicked, the user is taken to the output pane and shown the kernel channel for their interpreter.
This is a first pass for the info panel - additional information may be added based off feedback! Follow up work to add additional links to other channels is covered in #6149.
Release Notes
New Features
Bug Fixes
QA Notes
Screenshots
Feature Flag
Popup
Real-Time Session State Updates
Screen.Recording.2025-01-29.at.4.38.32.PM.mov