Rename extension - Part 1 - New name #56
Conversation
and offer to uninstall
We should be covered by the onStartupFinished and onLanguage events
| const language: ShinyliveLanguage = pathParts.includes("py") ? "py" : "r"; | ||
| const mode: ShinyliveMode = pathParts.includes("editor") ? "editor" : "app"; | ||
|
|
||
| return { | ||
| language: pathParts[1] as ShinyliveLanguage, | ||
| files: files as ShinyliveFile[], | ||
| mode: pathParts[2] as ShinyliveMode, | ||
| }; | ||
| return { language, mode, files: files as ShinyliveFile[] }; |
There was a problem hiding this comment.
Okay, technically this is an unrelated change and normally I'd do it in a separate PR. But this is small, easy, and actually has no impact other than making sure I don't forget. (We don't actually use language or mode, we only need files downstream of this function.)
|
Now that the old extension handles removing itself, if users install If users even realize that there's an issue, they could go to the old extension's setting page where they would see the page below. That said, once we send out the shell
|
| @@ -181,7 +181,7 @@ export async function shinyliveSaveAppFromUrl(): Promise<void> { | |||
|
|
|||
| const doc = await vscode.workspace.openTextDocument(localFiles[0]); | |||
|
|
|||
| await vscode.window.showTextDocument(doc, 2, false); | |||
| await vscode.window.showTextDocument(doc, undefined, false); | |||
There was a problem hiding this comment.
Another small quality of life change that's worth getting in: when we open the primary file of a Shinylive app after saving it locally, we now open the file in the current column (instead of the 2nd column).
Updates the extension ID to be
Posit.shinyand moves the extension tov1.0.0.The outdated extension points to this extension as a dependency and uninstalls itself upon activation.
For #53