-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename extension - Part 1 - New name #56
Conversation
and offer to uninstall
We should be covered by the onStartupFinished and onLanguage events
const language: ShinyliveLanguage = pathParts.includes("py") ? "py" : "r"; | ||
const mode: ShinyliveMode = pathParts.includes("editor") ? "editor" : "app"; | ||
|
||
return { | ||
language: pathParts[1] as ShinyliveLanguage, | ||
files: files as ShinyliveFile[], | ||
mode: pathParts[2] as ShinyliveMode, | ||
}; | ||
return { language, mode, files: files as ShinyliveFile[] }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, technically this is an unrelated change and normally I'd do it in a separate PR. But this is small, easy, and actually has no impact other than making sure I don't forget. (We don't actually use language
or mode
, we only need files
downstream of this function.)
Now that the old extension handles removing itself, if users install If users even realize that there's an issue, they could go to the old extension's setting page where they would see the page below. That said, once we send out the shell |
@@ -181,7 +181,7 @@ export async function shinyliveSaveAppFromUrl(): Promise<void> { | |||
|
|||
const doc = await vscode.workspace.openTextDocument(localFiles[0]); | |||
|
|||
await vscode.window.showTextDocument(doc, 2, false); | |||
await vscode.window.showTextDocument(doc, undefined, false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another small quality of life change that's worth getting in: when we open the primary file of a Shinylive app after saving it locally, we now open the file in the current column (instead of the 2nd column).
Updates the extension ID to be
Posit.shiny
and moves the extension tov1.0.0
.The outdated extension points to this extension as a dependency and uninstalls itself upon activation.
For #53