v0.3.0 - Deprecated Extension #57
Conversation
src/extension.ts
Outdated
| "shiny.shinylive.createFromExplorer", | ||
| shinyliveCreateFromExplorer | ||
| ) | ||
| export async function activate( |
There was a problem hiding this comment.
Either don't do this at all, or, unconditionally offer to uninstall yourself. (And remove that offer from Posit.shiny)
There was a problem hiding this comment.
Would it be crazy to unconditionally uninstall, without even asking?
There was a problem hiding this comment.
I went with the unconditional uninstall. I thought about including an informational message telling the user about the action but decided against it. Let me know if you'd like to add that back in.
| export async function activate(): Promise<void> { | ||
| // If the Posit.shiny extension is installed, this old shell extension is no | ||
| // longer needed. | ||
| if (!vscode.extensions.getExtension("Posit.shiny")) { |
There was a problem hiding this comment.
Since we have a dependency on Posit.shiny, is it even possible to get into this state?
There was a problem hiding this comment.
I don't think so? Or at least it's very unlikely. So this is purely defensive.
gadenbuie
changed the title
|
I've closed this PR but left the |
This replaces the
Posit.shiny-pythonextension with a shell extension thatPosit.shinyextension to ensure updating users get the new extension.For #53