-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.3.0 - Deprecated Extension #57
Conversation
src/extension.ts
Outdated
"shiny.shinylive.createFromExplorer", | ||
shinyliveCreateFromExplorer | ||
) | ||
export async function activate( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either don't do this at all, or, unconditionally offer to uninstall yourself. (And remove that offer from Posit.shiny
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be crazy to unconditionally uninstall, without even asking?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went with the unconditional uninstall. I thought about including an informational message telling the user about the action but decided against it. Let me know if you'd like to add that back in.
export async function activate(): Promise<void> { | ||
// If the Posit.shiny extension is installed, this old shell extension is no | ||
// longer needed. | ||
if (!vscode.extensions.getExtension("Posit.shiny")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we have a dependency on Posit.shiny, is it even possible to get into this state?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so? Or at least it's very unlikely. So this is purely defensive.
I've closed this PR but left the |
This replaces the
Posit.shiny-python
extension with a shell extension thatPosit.shiny
extension to ensure updating users get the new extension.For #53