Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Build .vsix and add to release assets #59

Closed
wants to merge 1 commit into from

Conversation

gadenbuie
Copy link
Collaborator

Adds a new job to automate building the vsix and adding to the release assets when a release is created.

Uses https://github.com/Shopify/upload-to-release

@gadenbuie gadenbuie requested a review from jcheng5 May 29, 2024 15:09
@jcheng5
Copy link
Collaborator

jcheng5 commented May 29, 2024

  1. Is the existence of the archives on VS Code Marketplace and Open-VSX not enough for you?
  2. Does it bother you at all that this is not the same binary as is actually published on those marketplaces? (They won't have the same hashes, even if the contents are the same)

Copy link
Collaborator

@jcheng5 jcheng5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this, but if you still want it I don't object.

@gadenbuie
Copy link
Collaborator Author

  • Is the existence of the archives on VS Code Marketplace and Open-VSX not enough for you?

I hadn't realized they existed. Idk, there's something appealing about keeping the history closer to the source. It occurred to me to look through our releases for the history but not the marketplace.

  • Does it bother you at all that this is not the same binary as is actually published on those marketplaces? (They won't have the same hashes, even if the contents are the same)

Not at all, it was more about keeping an artifact that could be used to manually install the extension at that point in time.

I don't think we need this, but if you still want it I don't object.

I have similar ambivalence, so I'll close this for now. If I feel differently in the future we can pull this back out.

@gadenbuie gadenbuie closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants