ci: clean up publish actions #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I’m confused why this was a bug before. We were running the publish jobs even when not tags, but any non-tags got the dry run flag set, right? |
@jcheng5 Yeah actually I think the bug was temporarily inside this PR. I don't think there's currently a bug on main, and there definitely wasn't before I made any changes to the publish job. Anyway, the behavior in this PR is what I want: only run the publish step on tag pushes to the |
jcheng5
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High priority follow up from #53, this finishes up the work in c348df2
We now only run the publish jobs when we're actually wanting to publish the extension, i.e. on tags pushed to the
posit-devowned repo. Note: this fixes a bug I introduced when working quickly to get the marketplace extension published.Otherwise we lint and build the extension, where building the extension also calls
yarn compile. This is a superset of what happens whendryRun: true, so the extra dry run publishing isn't required.The publish jobs fail silently if the extension is already published by setting
skipDuplicate: truein thepublish-vscode-extensionsettings.All jobs are fast enough that it's not worth the extra effort to download the vsix artifact in the publish jobs.