fix(certs): Show a proper error response for failed ACME validation r…

…equests
postalsys · Oct 18, 2024 · 71dfeba · 71dfeba
1 parent 3f967a9
commit 71dfeba
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/lib/routes-ui.js b/lib/routes-ui.js
@@ -9197,11 +9197,17 @@ return payload;`
             try {
                 challenge = await h.certs.routeHandler(domain, request.params.token);
                 if (!challenge) {
-                    throw new Error('Empty challenge');
+                    throw new Error('Challenge not found for the provided token and domain');
                 }
             } catch (err) {
-                let error = Boom.boomify(err, { statusCode: err.statusCode || 500 });
-                throw error;
+                return h
+                    .response(
+                        `Request failed: ${err.message}
+Domain: ${JSON.stringify(domain)}
+Token: ${JSON.stringify(request.params.token)}`
+                    )
+                    .type('text/plain')
+                    .code(err.statusCode || 500);
             }
 
             const response = h.response('success');