Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set outlook prompt authorization parameter #389

Closed
wants to merge 1 commit into from

Conversation

Crecket
Copy link

@Crecket Crecket commented Dec 11, 2023

For our usecase it is quite important that the user gets to pick which office account is used to authorize with Emailengine. Currently in some cases you are instantly logged in with your only active office account without being able to put in information for a different user during the login flow. This suggested change makes it so users are always shown a select account step during the office login flow.

The impact for users who are already logged in with the account they actually want to use is minimal as they can instantly click their account in the list and continue the rest of the usual login flow without having to re-enter their password. But users who wish to login with a different account now get to click "Use another account" option in outlook.

Docs for this option are found here, specifically the prompt parameter: https://learn.microsoft.com/en-us/entra/identity-platform/v2-oauth2-auth-code-flow#request-an-authorization-code

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@andris9
Copy link
Collaborator

andris9 commented Dec 11, 2023

Thanks for the PR. Unfortunately, I can't accept PRs without a signed CLA because the code is going to be owned by Postal Systems OÜ and not by the contributors. This is a reasonable change, though, and actually, the Gmail OAuth2 integration already uses the same param, so I committed the change by myself, see 1c6b56a

@andris9 andris9 closed this Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants