Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to 17beta3 #388

Merged
merged 1 commit into from
Aug 25, 2024
Merged

Upgrade to 17beta3 #388

merged 1 commit into from
Aug 25, 2024

Conversation

ImreSamu
Copy link
Member

I have made some changes to the PR:

  • Converted 17beta2 to 17beta3.
  • Ran ./update.sh to regenerate the Dockerfiles from the template.
  • Updated .github/workflows/main.yml and README.md.
  • Applied a temporary fix by updating the *-master/Dockerfiles GEOS_GIT_HASH commit to the 3.12 branch. The latest GEOS master (~3.13) caused the PostGIS regression test to fail.
    • in the code:
      • # geos - lock 3.12 branch
      • ENV GEOS_GIT_HASH 8fa289cf0146780a0be01e97501589b5a29224c4

Manually locking the PostGIS master GEOS hash to the 3.12 branch.
The GEOS master (3.13) has some test issues; the PostGIS regression test failed.
Copy link

coderabbitai bot commented Aug 20, 2024

Walkthrough

Walkthrough

The recent changes include upgrading the PostgreSQL version across several Dockerfiles and workflow configurations, transitioning from 17beta2 to 17beta3. Additionally, numerous environment variables reflecting Git commit hashes for dependencies were updated to ensure compatibility with newer library versions. The README.md was also revised to reflect these version changes, providing users with the most current information about PostGIS images.

Changes

Files Change Summary
.github/workflows/main.yml Updated PostgreSQL version from 17beta2 to 17beta3 in workflow configuration.
15-master/Dockerfile, 16-master/Dockerfile, 17beta3-master/Dockerfile Updated environment variables with new Git commit hashes for various dependencies (CGAL5X, SFCGAL, etc.).
17beta3-3.5.0alpha2/alpine/Dockerfile Changed base image from postgres:17beta2-alpine3.20 to postgres:17beta3-alpine3.20 and updated image description.
README.md Updated versioning information and table entries to reflect the transition from 17beta2 to 17beta3.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Workflow
    participant Dockerfile

    User->>Workflow: Trigger Build
    Workflow->>Dockerfile: Use PostgreSQL 17beta3
    Dockerfile->>Dependencies: Pull Latest Dependencies
    Dependencies->>Dockerfile: Use Updated Git Hashes
    Dockerfile->>User: Build Complete
Loading

🐰 In the garden where code does bloom,
A rabbit hops with joy and zoom,
PostgreSQL, now fresh and bright,
Upgraded with all its might!
Dependencies dance, in hashes they gleam,
For a smoother build, it’s a coder's dream! 🌼🚀


Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1cab507 and b1f6b5c.

Files selected for processing (6)
  • .github/workflows/main.yml (1 hunks)
  • 15-master/Dockerfile (6 hunks)
  • 16-master/Dockerfile (6 hunks)
  • 17beta3-3.5.0alpha2/alpine/Dockerfile (1 hunks)
  • 17beta3-master/Dockerfile (8 hunks)
  • README.md (2 hunks)
Files skipped from review due to trivial changes (2)
  • .github/workflows/main.yml
  • README.md
Additional comments not posted (23)
17beta3-3.5.0alpha2/alpine/Dockerfile (2)

4-4: Base image version update approved.

The base image has been updated to postgres:17beta3-alpine3.20, aligning with the PR objective to upgrade to 17beta3.


8-8: Image description label update approved.

The image description label now correctly reflects the upgrade to PostgreSQL 17beta3.

15-master/Dockerfile (6)

91-92: CGAL and SFCGAL Git hash updates approved.

The Git hashes for CGAL and SFCGAL have been updated to newer commits, ensuring compatibility with the latest improvements.


125-125: PROJ Git hash update approved.

The Git hash for PROJ has been updated to a newer commit, which may include important fixes or enhancements.


155-155: GEOS Git hash update approved.

The GEOS Git hash is now locked to a commit from the 3.12 branch, as mentioned in the PR summary. This is a temporary fix to address regression test failures.


171-171: GDAL Git hash update approved.

The GDAL Git hash has been updated to a newer commit, aligning with the latest available version.


304-308: Environment variable updates for final stage approved.

The environment variables for CGAL5X, SFCGAL, PROJ, GEOS, and GDAL have been updated in the final stage, ensuring consistency across the build process.


327-327: POSTGIS Git hash update approved.

The Git hash for POSTGIS has been updated, ensuring the use of the latest version.

16-master/Dockerfile (6)

91-92: CGAL and SFCGAL Git hash updates approved.

The Git hashes for CGAL and SFCGAL have been updated to newer commits, ensuring compatibility with the latest improvements.


125-125: PROJ Git hash update approved.

The Git hash for PROJ has been updated to a newer commit, which may include important fixes or enhancements.


155-155: GEOS Git hash update approved.

The GEOS Git hash is now locked to a commit from the 3.12 branch, as mentioned in the PR summary. This is a temporary fix to address regression test failures.


171-171: GDAL Git hash update approved.

The GDAL Git hash has been updated to a newer commit, aligning with the latest available version.


304-308: Environment variable updates for final stage approved.

The environment variables for CGAL5X, SFCGAL, PROJ, GEOS, and GDAL have been updated in the final stage, ensuring consistency across the build process.


327-327: POSTGIS Git hash update approved.

The Git hash for POSTGIS has been updated, ensuring the use of the latest version.

17beta3-master/Dockerfile (9)

10-10: Base image version update approved.

The base image has been updated to postgres:17beta3-bullseye, aligning with the PR objective to upgrade to 17beta3.


13-13: Image description label update approved.

The image description label now correctly reflects the upgrade to PostgreSQL 17beta3.


91-92: CGAL and SFCGAL Git hash updates approved.

The Git hashes for CGAL and SFCGAL have been updated to newer commits, ensuring compatibility with the latest improvements.


125-125: PROJ Git hash update approved.

The Git hash for PROJ has been updated to a newer commit, which may include important fixes or enhancements.


155-155: GEOS Git hash update approved.

The GEOS Git hash is now locked to a commit from the 3.12 branch, as mentioned in the PR summary. This is a temporary fix to address regression test failures.


171-171: GDAL Git hash update approved.

The GDAL Git hash has been updated to a newer commit, aligning with the latest available version.


255-255: Base image version update in final stage approved.

The base image has been updated to postgres:17beta3-bullseye in the final stage, ensuring consistency across the build process.


304-308: Environment variable updates for final stage approved.

The environment variables for CGAL5X, SFCGAL, PROJ, GEOS, and GDAL have been updated in the final stage, ensuring consistency across the build process.


327-327: POSTGIS Git hash update approved.

The Git hash for POSTGIS has been updated, ensuring the use of the latest version.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@phillipross phillipross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@ImreSamu ImreSamu merged commit 979f475 into postgis:master Aug 25, 2024
15 checks passed
@ImreSamu ImreSamu deleted the upgrade_17beta3 branch August 25, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants