-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed type errors happening frequently. #23
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"parserOptions": { | ||
"ecmaVersion": 2015 | ||
"ecmaVersion": 2020 | ||
}, | ||
"plugins": [ | ||
"security", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,78 @@ | ||
name: Draft new release | ||
|
||
on: | ||
workflow_dispatch: | ||
inputs: | ||
version: | ||
description: The version you want to release. Must be a valid semver version. | ||
required: true | ||
type: string | ||
|
||
jobs: | ||
draft-new-release: | ||
if: startsWith(github.event.inputs.version, 'v') | ||
name: Draft a new release | ||
runs-on: ubuntu-latest | ||
permissions: | ||
contents: write | ||
pull-requests: write | ||
|
||
steps: | ||
- name: Checkout code | ||
uses: actions/checkout@v3 | ||
|
||
- name: Create release branch | ||
run: git checkout -b release/${{ github.event.inputs.version }} | ||
|
||
- name: Update changelog | ||
uses: thomaseizinger/[email protected] | ||
with: | ||
version: ${{ github.event.inputs.version }} | ||
|
||
- name: Initialize mandatory git config | ||
run: | | ||
git config user.name "GitHub Actions" | ||
git config user.email [email protected] | ||
|
||
- name: Bump version | ||
run: npm version ${{ github.event.inputs.version }} --git-tag-version false | ||
|
||
- name: Commit changelog and manifest files | ||
id: make-commit | ||
run: | | ||
git add CHANGELOG.md package.json package-lock.json | ||
git commit --message "Prepare release ${{ github.event.inputs.version }}" | ||
echo "::set-output name=commit::$(git rev-parse HEAD)" | ||
|
||
- name: Push new branch | ||
run: git push origin release/${{ github.event.inputs.version }} | ||
|
||
- name: Create pull request for main | ||
uses: thomaseizinger/[email protected] | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
with: | ||
head: release/${{ github.event.inputs.version }} | ||
base: main | ||
title: "Release version ${{ github.event.inputs.version }}" | ||
reviewers: ${{ github.actor }} | ||
body: | | ||
Hi @${{ github.actor }}! | ||
|
||
This PR was created in response to a manual trigger of the release workflow here: https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}. | ||
I've updated the changelog and bumped the versions in the manifest files in this commit: ${{ steps.make-commit.outputs.commit }}. | ||
|
||
- name: Create pull request for development | ||
uses: thomaseizinger/[email protected] | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
with: | ||
head: release/${{ github.event.inputs.version }} | ||
base: development | ||
title: "Release version ${{ github.event.inputs.version }}" | ||
reviewers: ${{ github.actor }} | ||
body: | | ||
Hi @${{ github.actor }}! | ||
|
||
This PR was created in response to a manual trigger of the release workflow here: https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}. | ||
I've updated the changelog and bumped the versions in the manifest files in this commit: ${{ steps.make-commit.outputs.commit }}. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
name: "Publish new release" | ||
|
||
on: | ||
pull_request: | ||
branches: | ||
- main | ||
types: | ||
- closed | ||
|
||
jobs: | ||
release: | ||
name: Publish new release | ||
runs-on: ubuntu-latest | ||
# only merged pull requests that begin with 'release/' or 'hotfix/' must trigger this job | ||
if: github.event.pull_request.merged == true && | ||
(contains(github.event.pull_request.head.ref, 'release/') || contains(github.event.pull_request.head.ref, 'hotfix/')) | ||
permissions: | ||
contents: write | ||
|
||
steps: | ||
- name: Extract version from branch name (for release branches) | ||
if: contains(github.event.pull_request.head.ref, 'release/') | ||
run: | | ||
BRANCH_NAME="${{ github.event.pull_request.head.ref }}" | ||
VERSION=${BRANCH_NAME#release/} | ||
|
||
echo "RELEASE_VERSION=$VERSION" >> $GITHUB_ENV | ||
|
||
- name: Extract version from branch name (for hotfix branches) | ||
if: contains(github.event.pull_request.head.ref, 'hotfix/') | ||
run: | | ||
BRANCH_NAME="${{ github.event.pull_request.head.ref }}" | ||
VERSION=${BRANCH_NAME#hotfix/} | ||
|
||
echo "RELEASE_VERSION=$VERSION" >> $GITHUB_ENV | ||
|
||
- name: Create Release | ||
uses: thomaseizinger/[email protected] | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
with: | ||
target_commitish: ${{ github.event.pull_request.merge_commit_sha }} | ||
tag_name: ${{ env.RELEASE_VERSION }} | ||
name: ${{ env.RELEASE_VERSION }} | ||
draft: false | ||
prerelease: false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is urlParamsAsText always expected to be of type string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@agrwl-harsh Yes, we're directly using
.split()
function next line from this which should be only done if it's string to avoid typeerrors.