-
Notifications
You must be signed in to change notification settings - Fork 34
OBS-393 Simplify user interface for ECS installation #237
base: main
Are you sure you want to change the base?
Conversation
Small editorial updates
|
||
wf.ecsService = aws.ToString(service.ServiceName) | ||
wf.ecsServiceARN = arn(ecsServiceFlag) | ||
wf.ecsTaskDefinitionARN = arn(*service.TaskDefinition) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dereference without checking nil, what if there is no task registered yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A service can not be created without a task, we are fetching the service from AWS and using it's output to pick the taskARN
cmd/internal/ecs/add.go
Outdated
printer.Infof("Create a new version %d of task definition %q which includes the Postman Live Collections Agent as a sidecar.\n", | ||
printer.Infof("Create a new version of task definition %q which includes the Postman Live Collections Agent as a sidecar.\n", | ||
wf.ecsTaskDefinition.Revision+1, wf.ecsTaskDefinitionFamily) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You removed %d but kept it in the parameter list. We should specify the version number if it is still possible to do so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AWS auto-increments the revision numbers, we can't just do current + 1.
Revisions Status
1 Active
2 Active
3 Deployed in service
4 Active
5 Inactive(or even deleted aws remembers the highest count always)
New task definition revision will be 6, +1 would show incorrect value of 4.
For my testing i had deleted or marked inactive bunch of times, it always remembers the last highest + 1.
So this is not reliable without some sort of hack
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, good point. Do we show the revision number of our modified task anywhere in our output?
Fixes a small typo
…tasoftware/akita-cli into OBS-393-handle-more-than-10-services
Why ?
https://postman.slack.com/archives/C05SEPAHY1Z/p1695339058308279
What
New Usage
How
modifyTask
use RegisterTask to create a new definition withpostman-lc-agent
container as the side carupdateService
udpates the ECS service with new task definitionTicket link: https://postmanlabs.atlassian.net/browse/OBS-393