Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] libcurl: Free up headers list to prevent memory leak #726

Merged
merged 3 commits into from
Jan 18, 2024
Merged

[FIX] libcurl: Free up headers list to prevent memory leak #726

merged 3 commits into from
Jan 18, 2024

Conversation

aman-v-singh
Copy link
Contributor

VShingala
VShingala reviewed Jan 17, 2024
View reviewed changes
Copy link
Member

@VShingala VShingala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we look into failing unit tests and possibly fix them?

@VShingala
Copy link
Member

@aman-v-singh changes looks good but tests are still failing.

@aman-v-singh
Copy link
Contributor Author

@aman-v-singh changes look good but tests are still failing.

@VShingala The unit tests that are failing are unrelated to the changes in this PR. We can probably merge this PR while I parallelly try to resolve most of the issues locally.

@VShingala
Copy link
Member

@VShingala The unit tests that are failing are unrelated to the changes in this PR. We can probably merge this PR while I parallelly try to resolve most of the issues locally.

Ok, I'll proceed with merge then.

@VShingala VShingala merged commit c347472 into develop Jan 18, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VShingala VShingala VShingala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aman-v-singh @VShingala