modify the handling of invalid names in getPath, returning empty stri…

…ng for invalid name item
postmanlabs · Oct 17, 2023 · 6d24c87 · 6d24c87
1 parent 3ac1177
commit 6d24c87
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/lib/collection/item.js b/lib/collection/item.js
@@ -337,16 +337,14 @@ _.assign(Item.prototype, /** @lends Item.prototype */ {
      * @returns {Array<string>}
      */
     getPath: function () {
-        const path = [];
-
-        if (typeof this.name === 'string') {
-            const pushItem = (item) => {
+        const path = [],
+            pushItem = (item) => {
                 path.push(item.name || '');
             };
 
-            pushItem(this);
-            this.forEachParent({ withRoot: true }, pushItem);
-        }
+        pushItem(this);
+        this.forEachParent({ withRoot: true }, pushItem);
+
 
         return path.reverse();
     }

diff --git a/test/unit/item.test.js b/test/unit/item.test.js
@@ -223,7 +223,7 @@ describe('Item', function () {
                 f1 = collection.items.members[0],
                 r1 = f1.items.members[0];
 
-            expect(r1.getPath()).to.deep.equal([]);
+            expect(r1.getPath()).to.deep.equal(['', '', '']);
         });
     });