wip: add support for lazily replacing variables #1388
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pranav2612000
force-pushed
the
feat/add-support-for-lazy-replacer
branch
from
1770756 to
2219c42
Compare
Pranav2612000
commented
Nov 25, 2024
| // convert the variables to a substitutor object (will not reconvert if already substitutor) | ||
| variables = Substitutor.box(variables, Substitutor.DEFAULT_VARS); | ||
|
|
||
| const promises = []; |
There was a problem hiding this comment.
@appurva21 Thoughts on supporting async updates this way? This feels weird but I didn't want to touch the _.mergeWith and customizer fns. Or do you think it's okay if we write a custom implementation for mergeWith which supports async replaces ?
Pranav2612000
commented
Nov 25, 2024
| @@ -208,6 +222,7 @@ _.assign(Variable.prototype, /** @lends Variable.prototype */ { | |||
| _.has(options, 'system') && (this.system = options.system); | |||
| _.has(options, 'disabled') && (this.disabled = options.disabled); | |||
| _.has(options, 'description') && (this.describe(options.description)); | |||
| _.has(options, 'lazy') && (this.lazy = options.lazy); | |||
There was a problem hiding this comment.
@appurva21 Thoughts on this approach?
The advantage is that it makes it clear which variables are to be resolved lazily, and which are to be replaced immediately. The disadvantage is that lazy has no meaning for replaceSubstitutions ( non lazy ), and makes the replaceSubstitutionsLazy interface more complicated.
Some other approaches I thought about
- A) lazily replace all values ( when invoked through
replaceSubstitutionsLazy) but this increases the amount of memory needed, and slightly slows down the function. - B) Only lazily replace
Promisevalues. This is a good solution but there is no reliable method of identifying if something is a promise or not. ( Duck typing is not accurate ) - C) Only lazily replace function values. Could be a good tradeoff but has the same problems as (A), also makes the code slightly less intuitive.
Pranav2612000
force-pushed
the
feat/add-support-for-lazy-replacer
branch
from
7d554c9 to
9507de0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.