Merge pull request #27 from potsrevennil/dev

Dev

.github/actions/bench/action.yml

@@ -70,25 +70,15 @@ runs:
     - name: Run benchmark
       shell: ${{ env.SHELL }}
       run: |
-        ./scripts/tests bench -c ${{ inputs.perf }} --cross-prefix="${{ inputs.cross_prefix }}" \
-              --cflags="${{ inputs.cflags }}" --arch-flags="${{ inputs.archflags }}" \
-              --opt=$([[ ${{ inputs.opt }} == "false" ]] && echo "no_opt" || echo "opt")  \
-              -v --output=output.json ${{ inputs.bench_extra_args }}
-
-        ./scripts/tests bench --components -c ${{ inputs.perf }} --cross-prefix="${{ inputs.cross_prefix }}" \
-              --cflags="${{ inputs.cflags }}" --arch-flags="${{ inputs.archflags }}" \
-              --opt=$([[ ${{ inputs.opt }} == "false" ]] && echo "no_opt" || echo "opt")  \
-              -v --output=output.json ${{ inputs.bench_extra_args }}
-    - name: Check namespace
-      shell: ${{ env.SHELL }}
-      run: |
-        check-namespace
+        ./scripts/bench
     - name: Store benchmark result
-      if: ${{ inputs.store_results == 'true' }}
       uses: benchmark-action/github-action-benchmark@v1
       with:
         name: ${{ inputs.name }}
         tool: "customSmallerIsBetter"
         output-file-path: output.json
         github-token: ${{ inputs.gh_token }}
-        auto-push: true
+        auto-push: ${{ inputs.store_results == 'true' }}
+        comment-on-alert: true
+        summary-always: true
+        alert-threshold: 103%

.github/workflows/bench.yml

@@ -1,21 +1,35 @@
 # SPDX-License-Identifier: Apache-2.0
 
 name: Bench
-permissions:
-  contents: read
 on:
   workflow_dispatch:
   push:
     branches: ["main"]
   pull_request:
     branches: ["main"]
-    types: [ "labeled" ]
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
   cancel-in-progress: true
 
 jobs:
+  bench-test:
+    permissions:
+      contents: write
+      pull-requests: write
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+      - uses: ./.github/actions/bench
+        with:
+          nix-shell: ''
+          name: test
+          archflags: -mavx2 -mbmi2 -mpopcnt -maes
+          cflags: -DFORCE_X86_64
+          perf: PMU
+          store_results: ${{ github.ref == 'refs/heads/main' }}
+          gh_token: ${{ secrets.GITHUB_TOKEN }}
+          opt: true
   bench:
     name: ${{ matrix.target.name }}
     strategy:
@@ -56,7 +70,7 @@ jobs:
   ec2_all:
     name: ${{ matrix.target.name }} ${{ matrix.opt.name }}
     permissions:
-      contents: 'read'
+      contents: 'write'
       id-token: 'write'
     strategy:
       fail-fast: false

scripts/bench

@@ -0,0 +1,37 @@
+#!/usr/bin/env python3
+# SPDX-License-Identifier: Apache-2.0
+
+import json
+from enum import IntEnum
+
+output = "output.json"
+
+
+class SCHEME(IntEnum):
+    MLKEM512 = 1
+    MLKEM768 = 2
+    MLKEM1024 = 3
+
+    def __str__(self):
+        match self:
+            case SCHEME.MLKEM512:
+                return "ML-KEM-512"
+            case SCHEME.MLKEM768:
+                return "ML-KEM-768"
+            case SCHEME.MLKEM1024:
+                return "ML-KEM-1024"
+
+
+with open(output, "w") as f:
+    v = []
+    for scheme in SCHEME:
+        for primitive in ["keypair", "encaps", "decaps"]:
+            v.append(
+                {
+                    "name": f"{str(scheme)} {primitive}",
+                    "unit": "cycles",
+                    "value": 1234567,
+                }
+            )
+
+    f.write(json.dumps(v))