Utilities/ImageTools #327
Merged
Utilities/ImageTools #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borut-t
force-pushed
the
utilities/image-tools
branch
from
9e088a8
to
2d2b0f8
Compare
markom-povio
approved these changes
Jul 31, 2024
dejanskledar
reviewed
Aug 1, 2024
There was a problem hiding this comment.
Godo job!
Another addition, would be to compress/reduce size to a max size, eg. if server expects an image that is max 1MB, a nice method would be
func compress(image: UIImage, toMaxKbSize size: CGFloat) throws -> Data Also, lets use Swift syntax with labeled parameters? Its such a great concept Swift offers, its really a shame we omit it, feels like a step back 😅
tonikocjan
reviewed
Aug 2, 2024
borut-t
force-pushed
the
utilities/image-tools
branch
from
e75e9c1
to
7b85feb
Compare
borut-t
force-pushed
the
utilities/image-tools
branch
from
7b85feb
to
4eacbe2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A set of image tools bundled in a handy
UIImageextension. Some methods depends on the Kingfisher library, therefore it needs to be installed in the project in order to leverage them.