Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue179/processor actors #208

Merged
merged 35 commits into from
Nov 9, 2023
Merged

Conversation

roda82
Copy link
Contributor

@roda82 roda82 commented Nov 8, 2023

Closes: #179

roda82 added 26 commits July 26, 2023 16:28
…per. Add binding manager for this kind of actor
…ors parsing for including bindings to pullers/pushers, remove bindings as first class entities
… updates in K8sPreProcessorActor, Adapt tests, Remove unnecessary code
…tween processors and pullers/pushers and its related tests, Improve K8sMonitorAgent exception management
powerapi/processor/pre/k8s/k8s_monitor.py Fixed Show fixed Hide fixed
powerapi/processor/pre/k8s/k8s_monitor.py Fixed Show fixed Hide fixed
tests/unit/cli/test_generator.py Fixed Show fixed Hide fixed
tests/unit/cli/test_generator.py Fixed Show fixed Hide fixed
def __init__(self, component_group_name: str):
Generator.__init__(self, component_group_name=component_group_name)

self.processor_factory = self._get_default_processor_factories()

Check warning

Code scanning / CodeQL

`__init__` method calls overridden method Warning

Call to self.
_get_default_processor_factories
in __init__ method, which is overridden by
method PreProcessorGenerator._get_default_processor_factories
.
Call to self.
_get_default_processor_factories
in __init__ method, which is overridden by
method PostProcessorGenerator._get_default_processor_factories
.
tests/unit/cli/conftest.py Fixed Show fixed Hide fixed
@gfieni gfieni self-requested a review November 8, 2023 14:36
@gfieni gfieni added the enhancement New feature or request label Nov 8, 2023
gfieni

This comment was marked as outdated.

@gfieni gfieni self-requested a review November 8, 2023 14:51
@gfieni gfieni dismissed their stale review November 8, 2023 14:52

No ref to code in the review

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #208 (f4a7765) into master (d598154) will increase coverage by 0.00%.
Report is 57 commits behind head on master.
The diff coverage is 66.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #208    +/-   ##
========================================
  Coverage   65.62%   65.62%            
========================================
  Files          83       88     +5     
  Lines        3296     3782   +486     
========================================
+ Hits         2163     2482   +319     
- Misses       1133     1300   +167     
Files Coverage Δ
powerapi/actor/state.py 70.58% <100.00%> (ø)
powerapi/handler/handler.py 48.00% <100.00%> (ø)
powerapi/handler/poison_pill_message_handler.py 36.36% <100.00%> (+3.03%) ⬆️
powerapi/message.py 80.32% <ø> (+0.64%) ⬆️
powerapi/puller/puller_actor.py 92.30% <100.00%> (-0.29%) ⬇️
powerapi/puller/simple/simple_puller_actor.py 85.71% <ø> (ø)
powerapi/puller/simple/simple_puller_handlers.py 39.28% <100.00%> (+2.24%) ⬆️
powerapi/actor/actor.py 51.54% <50.00%> (-0.50%) ⬇️
powerapi/processor/processor_actor.py 94.73% <94.73%> (ø)
powerapi/dispatcher/dispatcher_actor.py 65.45% <60.00%> (-0.55%) ⬇️
... and 14 more

Comment on lines +35 to +36
from powerapi.cli.generator import PullerGenerator, PusherGenerator, ProcessorGenerator, COMPONENT_TYPE_KEY, \
LISTENER_ACTOR_KEY, MONITOR_NAME_SUFFIX, PreProcessorGenerator

Check notice

Code scanning / CodeQL

Unused import Note test

Import of 'ProcessorGenerator' is not used.
Copy link

sonarqubecloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@roda82 roda82 merged commit 23e74eb into master Nov 9, 2023
8 checks passed
@roda82 roda82 deleted the feature/issue179/processor-actors branch November 9, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creation of Processor Actors
2 participants