addressing feedback

powerhome · Sep 26, 2024 · 864e1e1 · 864e1e1
1 parent 4e131cf
commit 864e1e1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/playbook/app/pb_kits/playbook/pb_dropdown/_dropdown.tsx b/playbook/app/pb_kits/playbook/pb_dropdown/_dropdown.tsx
@@ -36,7 +36,7 @@ type DropdownProps = {
     onSelect?: (arg: GenericObject) => null;
     options: GenericObject;
     triggerRef?: any;
-    variant?: string;
+    variant?: "primary" | "subtle";
 };
 
 const Dropdown = (props: DropdownProps) => {
@@ -57,7 +57,7 @@ const Dropdown = (props: DropdownProps) => {
         onSelect,
         options,
         triggerRef,
-        variant
+        variant = "primary"
     } = props;
 
     const ariaProps = buildAriaProps(aria);

diff --git a/playbook/app/pb_kits/playbook/pb_dropdown/docs/_dropdown_subtle_variant.jsx b/playbook/app/pb_kits/playbook/pb_dropdown/docs/_dropdown_subtle_variant.jsx
@@ -20,13 +20,13 @@ const DropdownSubtleVariant = (props) => {
 
 
   return (
-  <div>
-    <Dropdown
-        options={options}
-        variant="subtle"
-        {...props}
-    />
-  </div>
+    <>
+      <Dropdown
+          options={options}
+          variant="subtle"
+          {...props}
+      />
+    </>
   )
 }