Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PBNTR-389](Dropdown work - States & Variant Prop [ 1 of 5]) #3736

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

nickamantia
Copy link
Contributor

@nickamantia nickamantia commented Sep 26, 2024

PBNTR-389

This PR adds new state styles and a variant prop with a subtle doc example!

Screenshot 2024-09-30 at 2 04 45 PM

How to test? Steps to confirm the desired behavior:

  1. Go to the dropdown kit and confirm styles!

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@nickamantia nickamantia self-assigned this Sep 26, 2024
@nickamantia nickamantia added milano 20 MAX - Deploy this PR to a review environment via Milano enhancement New Features, Props, & Variants (USED IN CHANGELOG) labels Sep 26, 2024
@nickamantia nickamantia marked this pull request as ready for review September 26, 2024 15:25
@nickamantia nickamantia requested review from a team as code owners September 26, 2024 15:25
carloslimasd
carloslimasd previously approved these changes Sep 26, 2024
@powerhome-portal
Copy link

A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=pbntr-389-dropdown-states-and-variant-prop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Approved Approved by a Playbook Admin enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants