-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PBNTR-389](Dropdown work - States & Variant Prop [ 1 of 5]) #3736
Open
nickamantia
wants to merge
10
commits into
master
Choose a base branch
from
pbntr-389-dropdown-states-and-variant-prop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+187
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickamantia
added
milano
20 MAX - Deploy this PR to a review environment via Milano
enhancement
New Features, Props, & Variants (USED IN CHANGELOG)
labels
Sep 26, 2024
playbook/app/pb_kits/playbook/pb_dropdown/docs/_dropdown_subtle_variant.jsx
Outdated
Show resolved
Hide resolved
carloslimasd
previously approved these changes
Sep 26, 2024
A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=pbntr-389-dropdown-states-and-variant-prop |
nidaqg
reviewed
Oct 4, 2024
nidaqg
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Code Approved
Approved by a Playbook Admin
enhancement
New Features, Props, & Variants (USED IN CHANGELOG)
milano
20 MAX - Deploy this PR to a review environment via Milano
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PBNTR-389
This PR adds new state styles and a variant prop with a subtle doc example!
How to test? Steps to confirm the desired behavior:
Checklist:
enhancement
,bug
,improvement
,new kit
,deprecated
, orbreaking
. See Changelog & Labels for details.milano
label to show I'm ready for a review.