Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAY-1592] Show htmlOptions as a Global Prop #3755

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

skduncan
Copy link
Contributor

@skduncan skduncan commented Oct 2, 2024

What does this PR do? A clear and concise description with your runway ticket url.
PLAY-1592

As a Playbook user, I want the htmlOptions prop to display in Playbook as a global prop instead of a kit prop (which is false) so that there is no confusion to what type of prop htmlOptions is.

Screenshots: Screenshots to visualize your addition/change

How to test? Steps to confirm the desired behavior:

  1. Go to any kit page
  2. Ensure you are in the react tab
  3. Scroll down to the available props list
  4. The "htmlOptions" prop should not appear under the kit props list, but will show under the global props list.

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.

@skduncan skduncan added milano 20 MAX - Deploy this PR to a review environment via Milano improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) labels Oct 2, 2024
@skduncan skduncan requested review from a team as code owners October 2, 2024 18:03
@nidaqg nidaqg added the Code Approved Approved by a Playbook Admin label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Approved Approved by a Playbook Admin improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) milano 20 MAX - Deploy this PR to a review environment via Milano
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants