Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAY-1548] Upgrade intl-tel-input to Latest and Make Fixes #3791

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

kangaree
Copy link
Contributor

IN PROGRESS - DO NOT MERGE

What does this PR do?

  • Bump intl-tel-input from 18.0.15 to 24.5.2
  • Use intlTelInput from package instead of window
  • Update class names (e.g., flag -> country)
  • Turn off "country search" default
  • Change dropdown to not be the full width of the input
  • Use utils so a placeholder is added
  • Make various CSS fixes
  • Add a "globe" default
  • Change "preferredCountries" to new "countryOrder" prop

Screenshots: Screenshots to visualize your addition/change
Playbook Design System 2024-10-11 at 3 10 31 PM

How to test? Steps to confirm the desired behavior:

  1. Go to the Phone Number Input Kit
  2. Test all doc examples for both Rails and React
  3. Test on Nitro.

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.

@kangaree kangaree added milano 20 MAX - Deploy this PR to a review environment via Milano improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) labels Oct 11, 2024
@kangaree kangaree added the alpha label Oct 11, 2024
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 14.5.0.pre.alpha.PLAY1548intltelinputupdatelatest4028

Your Alpha for NPM is 14.5.0-alpha.PLAY1548intltelinputupdatelatest4028

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) milano 20 MAX - Deploy this PR to a review environment via Milano
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant